unity-2d

Merge lp://qastaging/~mardy/unity-2d/geometry into lp://qastaging/unity-2d

  1. geometry
  2. Merge into trunk
Proposed by Alberto Mardegan
Status: Superseded
Proposed branch: lp://qastaging/~mardy/unity-2d/geometry
Merge into: lp://qastaging/unity-2d
Prerequisite: lp://qastaging/~mardy/unity-2d/launcher-bg
Diff against target: 200 lines (+16/-33)
7 files modified
libunity-2d-private/src/screeninfo.cpp (+7/-0)
libunity-2d-private/src/screeninfo.h (+3/-0)
places/app/dashdeclarativeview.cpp (+2/-17)
places/app/dashdeclarativeview.h (+0/-7)
spread/Windows.qml (+0/-5)
spread/Workspaces.qml (+3/-3)
spread/app/spreadview.cpp (+1/-1)
To merge this branch: bzr merge lp://qastaging/~mardy/unity-2d/geometry
Reviewer Review Type Date Requested Status
Florian Boucault (community) Needs Fixing
Review via email: mp+80051@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2011-10-21.

Description of the change

Better handling of screen geometry

Revert change introduced in revision 752 where the semantics of ScreenInfo::availableGeometry() where changed.
Now that method will return the same as QDesktopWidget::availableGeometry() returns; instead, a new method ScreenInfo::panelsFreeGeometry() will return the available geometry minus the launcher.

Also, a the screenGeometry and availableGeometry properties were removed from the DashDeclarative class, because they were unused (and ScreenInfo provides the same information).

To post a comment you must log in.
Revision history for this message
Florian Boucault (fboucault) wrote :

If you could also remove the various instantiation of ScreenInfo and replace them with using ScreenInfo::instance() that'd be perfect.

review: Needs Fixing
Revision history for this message
Florian Boucault (fboucault) wrote :

I believe the two instances of this are:

DashDeclarativeView.m_screenInfo
SpreadView.m_screenInfo

Revision history for this message
Florian Boucault (fboucault) wrote :

Is there a bug report for the background jumping issue we could link to?

lp://qastaging/~mardy/unity-2d/geometry updated
770. By Alberto Mardegan

Remove storing of ScreenInfo instance in object private data

Revision history for this message
Lohith D Shivamurthy (dyams) wrote :

Would like to suggest the following:

1) Change the name of the following methods:

     • Current name : DashDeclarativeView::fitToAvailableSpace
       New Name : DashDeclarativeView::resizeToFullscreenMode()

     • Current name : DashDeclarativeView::resizeToDesktopModeSize()
       New name : DashDeclarativeView::resizeToDesktopMode()

2) Similar to ScreenInfo, Could we also make 'LauncherClicent' a singleton? It has three instances now.

Revision history for this message
Alberto Mardegan (mardy) wrote :

Lohith, this merge request has been superseded by https://code.launchpad.net/~mardy/unity-2d/geometry/+merge/80071

Revision history for this message
Lohith D Shivamurthy (dyams) wrote :

This branch is moved to new location.
Please follow the new branch here
https://code.launchpad.net/~dyams/unity-2d/mardy-geometry/+merge/83767

Thank you

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches