Merge into trunk : creation-mode : Code : webbrowser-app

Status:	Rejected
Rejected by:	Alberto Mardegan on 2014-03-28
Proposed branch:	lp://qastaging/~mardy/webbrowser-app/creation-mode
Merge into:	lp://qastaging/webbrowser-app
Prerequisite:	lp://qastaging/~mardy/webbrowser-app/oa-runtime
Diff against target:	115 lines (+26/-5) 4 files modified src/app/browserapplication.cpp (+7/-2) src/app/browserapplication.h (+8/-2) src/app/webcontainer/sqlitecookiestore.cpp (+8/-0) src/app/webcontainer/webapp-container.cpp (+3/-1)
To merge this branch:	bzr merge lp://qastaging/~mardy/webbrowser-app/creation-mode
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Alexandre Abreu (community)		2014-03-06	Approve on 2014-03-06
PS Jenkins bot	continuous-integration		Approve on 2014-03-06
Ubuntu Phablet Team		2014-03-06	Pending
Review via email: mp+209672@code.qastaging.launchpad.net

Commit message

Don't load the webview as soon as a webapp starts

The code in webapp-container.qml initially checks the value of its
"accountProvider" property and loads the webview if that's empty.
If this property is set after the component has been built, this will cause the
webview to be (accidentally) loaded for a fraction of a second, which in turn
will cause the WebProcess to be spawned. The WebProcess will read the
cookies.db file, and the same WebProcess instance will likely be reused for the
webapp, once we really want to use it. This has the unfortunate side-effect
that it will not re-read the cookies which we might have copied over from
Online Accounts in the meantime.

So, with this change we make sure that all properties (including
"accountProvider") will be set on the Window before the component is completed.

Description of the change

Don't load the webview as soon as a webapp starts

The code in webapp-container.qml initially checks the value of its
"accountProvider" property and loads the webview if that's empty.
If this property is set after the component has been built, this will cause the
webview to be (accidentally) loaded for a fraction of a second, which in turn
will cause the WebProcess to be spawned. The WebProcess will read the
cookies.db file, and the same WebProcess instance will likely be reused for the
webapp, once we really want to use it. This has the unfortunate side-effect
that it will not re-read the cookies which we might have copied over from
Online Accounts in the meantime.

So, with this change we make sure that all properties (including
"accountProvider") will be set on the Window before the component is completed.