webbrowser-app

Merge lp://qastaging/~mardy/webbrowser-app/lp1302780 into lp://qastaging/webbrowser-app

lp1302780
Merge into trunk

Proposed by Alberto Mardegan on 2014-04-23

Status:

Merged

Merge reported by:

Olivier Tilloy

Merged at revision:

not available

Proposed branch:

lp://qastaging/~mardy/webbrowser-app/lp1302780

Merge into:

lp://qastaging/webbrowser-app

Diff against target:

29 lines (+19/-0)

1 file modified

src/app/webcontainer/WebViewImplOxide.qml (+19/-0)

To merge this branch:

bzr merge lp://qastaging/~mardy/webbrowser-app/lp1302780

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Needs Fixing on 2014-05-06
Alexandre Abreu (community)		2014-04-23	Approve on 2014-04-29
Review via email: mp+216876@code.qastaging.launchpad.net

Commit message

Webapps: let SAML requests through

SAML requests are used for instance by Google Apps for your domain; they are implemented as a HTTP redirect to a URL containing the query parameter called "SAMLRequest".
Besides letting the request through, we must also add the SAML domain to the list of the allowed hosts.

Description of the change

Webapps: let SAML requests through

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-04-23:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/769/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~mardy/webbrowser-app/lp1302780 updated on 2014-04-28

503. By Alberto Mardegan on 2014-04-28

Merge from trunk

[ Ubuntu daily release ]
* New rebuild forced
[ Alexandre Abreu ]
* Fix the network dialog reload (LP: #1309138)
* Oxide (and Chromium) does not inform of non user driven navigations
  (or more specifically redirects that would be part of an
  popup/webview load (after its been granted). Quite a few sites (e.g.
  Youtube), create popups when clicking on links (or following a
  window.open()) with proper youtube.com address but w/ redirection
  params, e.g.:
  http://www.youtube.com/redirect?q=http%3A%2F%2Fgodzillamovie.com%2F&
  redir_token=b8WPI1pq9FHXeHm2bN3KVLAJSfp8MTM5NzI2NDg3NEAxMzk3MTc4NDc0
  In this instance the popup & navigation is granted, but then a
  redirect happens inside the popup to the real target url (here
  http://godzillamovie.com) which is not trapped by a navigation
  requested and therefore not filtered. The only way to do it atm is
  to listen to url changes in popups & also filter there. (LP:
  #1294279)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-04-28:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/780/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Alexandre Abreu (abreu-alexandre) wrote on 2014-04-28:

A few comments:
- could you make sure that it works also for other schemes than http ? although quite unlikely (bc of the "SAMLRequest") it would fail if it happens,
- The "SAMLRequest" string index is searched in the whole URL not in the query param, which is open door to any website w/ a link to e.g. http://www.blabla.SAMLRequest/* to be whitelisted