webbrowser-app

Merge lp://qastaging/~mardy/webbrowser-app/no-content-hub into lp://qastaging/webbrowser-app

  1. no-content-hub
  2. Merge into trunk
Proposed by Alberto Mardegan
Status: Needs review
Proposed branch: lp://qastaging/~mardy/webbrowser-app/no-content-hub
Merge into: lp://qastaging/webbrowser-app
Diff against target: 25 lines (+3/-1)
2 files modified
src/app/Downloader.qml (+1/-0)
src/app/WebViewImpl.qml (+2/-1)
To merge this branch: bzr merge lp://qastaging/~mardy/webbrowser-app/no-content-hub
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+322092@code.qastaging.launchpad.net

Commit message

Don't use the ContentHub-based downloader if the service is not available

This change makes use of the "valid" property added to the ContentHub singleton in
https://code.launchpad.net/~mardy/content-hub/valid-1676893/+merge/322091

Description of the change

Don't use the ContentHub-based downloader if the service is not available

This change makes use of the "valid" property added to the ContentHub singleton in
https://code.launchpad.net/~mardy/content-hub/valid-1676893/+merge/322091

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

PASSED: Continuous integration, rev:1587
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/5/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/2472
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2472
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2283
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2283/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2283
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2283/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2283
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2283/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2283
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2283/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2283
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2283/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2283
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2283/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/5/rebuild

review: Approve (continuous-integration)
Reply

Unmerged revisions

1587. By Alberto Mardegan

Don't use ContentHub APIs if service unavailable

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: