webbrowser-app

Merge lp://qastaging/~mardy/webbrowser-app/plus-1644585 into lp://qastaging/webbrowser-app

  1. plus-1644585
  2. Merge into trunk
Proposed by Alberto Mardegan
Status: Rejected
Rejected by: Olivier Tilloy
Proposed branch: lp://qastaging/~mardy/webbrowser-app/plus-1644585
Merge into: lp://qastaging/webbrowser-app
Diff against target: 27 lines (+6/-0)
2 files modified
src/Ubuntu/Web/ua-overrides-desktop.js.in (+3/-0)
src/Ubuntu/Web/ua-overrides-mobile.js.in (+3/-0)
To merge this branch: bzr merge lp://qastaging/~mardy/webbrowser-app/plus-1644585
Reviewer Review Type Date Requested Status
Olivier Tilloy Disapprove
system-apps-ci-bot continuous-integration Needs Fixing
Review via email: mp+312131@code.qastaging.launchpad.net

Commit message

Add overrides for Google+

Description of the change

Add overrides for Google+

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1560
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/729/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/2084/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2087
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1917
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1917/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1917/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1917
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1917/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1917/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1917
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1917/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1917
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1917/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1917
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1917/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1917/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1917
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1917/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-webbrowser-app-ci/729/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

Is the override for desktop really needed? I’m seeing the issue only on mobile myself.

review: Needs Information
Revision history for this message
Alberto Mardegan (mardy) wrote :

As far as I could see, the issue happens on mobile only. I thought of playing safe and add it to the desktop too, but let me know if I should remove it.

Revision history for this message
Olivier Tilloy (osomon) wrote :

Thanks Alberto. I am actually seeing an issue on desktop too. When logging in to plus.google.com with my @canonical.com account, I’m consistently getting a 404 (this has been confirmed by Pat too). So it looks like a desktop override is going to be needed, although not the one you added (which has an "android" token in it).

Revision history for this message
Olivier Tilloy (osomon) wrote :

This was fixed in a different branch (bug #1656310).

review: Disapprove

Unmerged revisions

1560. By Alberto Mardegan

Add override for google+

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: