webbrowser-app

Merge lp://qastaging/~mardy/webbrowser-app/skip-selection into lp://qastaging/~abreu-alexandre/webbrowser-app/add-onlineaccount-support-for-container

  1. skip-selection
  2. Merge into add-onlineaccount-support-...
Proposed by Alberto Mardegan
Status: Merged
Approved by: Alexandre Abreu
Approved revision: 438
Merged at revision: 436
Proposed branch: lp://qastaging/~mardy/webbrowser-app/skip-selection
Merge into: lp://qastaging/~abreu-alexandre/webbrowser-app/add-onlineaccount-support-for-container
Diff against target: 134 lines (+30/-39)
3 files modified
src/app/webcontainer/AccountsLoginPage.qml (+27/-18)
src/app/webcontainer/AccountsModel.qml (+1/-2)
src/app/webcontainer/AccountsView.qml (+2/-19)
To merge this branch: bzr merge lp://qastaging/~mardy/webbrowser-app/skip-selection
Reviewer Review Type Date Requested Status
Alexandre Abreu Approve
Review via email: mp+207649@code.qastaging.launchpad.net

Commit message

Skip account selection if there's only one account

Description of the change

Skip account selection if there's only one account

To post a comment you must log in.
lp://qastaging/~mardy/webbrowser-app/skip-selection updated
437. By Alberto Mardegan

Expose count property in AccountsModel

Remove the unused countChanged() signal

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

your branch fails for me ... when you have no account, you cannot see the page that allows you to possibly choose to create one. I see a glimpse of the page & then it transitions to the webview

review: Needs Fixing
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

L40: not sure I understand why you removed it, from where accountServiceHandle is supposed to come from then? eg. in the case of multiple accounts being present and one being selected, accountServiceHandle is supposed to come from accountSelected(accountServiceHandle) which needs the delegate ...

lp://qastaging/~mardy/webbrowser-app/skip-selection updated
438. By Alberto Mardegan

Simplify AccountsView

Revision history for this message
Alberto Mardegan (mardy) wrote :

> L40: not sure I understand why you removed it, from where accountServiceHandle
> is supposed to come from then? eg. in the case of multiple accounts being
> present and one being selected, accountServiceHandle is supposed to come from
> accountSelected(accountServiceHandle) which needs the delegate ...

I thought that that function was not used anywhere, but I missed the AccountsView. Now I've simplified that, so that the function is really never used (and even more code is removed). :-)

Revision history for this message
Alexandre Abreu (abreu-alexandre) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches