Juju Charms Collection
percona-cluster package

Reviewer	Date Requested	Status
James Page	2015-03-09	Needs Fixing on 2015-03-31
Felipe Reyes	2015-03-09	Needs Fixing on 2015-03-11
Edward Hope-Morley	2015-03-09	Pending
Billy Olsen	2015-03-09	Pending
Jorge Niedbalski	2015-03-09	Pending
Review via email: mp+252248@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2015-10-14.

Description of the change

This adds two charm configuration options - enable_binlogs and binlogs_path. Binlog_path defaults to /var/log/mysql/mysql.bin (it's because my.cnf which is packaged with mysql-common package suggests that location, and also because mysql charm defaults with binlogs at that location), while enable_binlogs defaults to 'False'.

Revision history for this message

Felipe Reyes (freyes) wrote on 2015-03-11:

Hi Mario,

This feature makes a lot of sense, and it worked for me, but please add unit tests for your patch, I also have minor comments in the diff.

Thanks,

review: Needs Fixing

Revision history for this message

James Page (james-page) wrote on 2015-03-31:

bzr merge lp:~mariosplivalo/charms/trusty/percona-cluster/enable-binlogs
...
Text conflict in hooks/charmhelpers/contrib/database/mysql.py
1 conflicts encountered.

review: Needs Fixing

Revision history for this message

James Page (james-page) on 2015-03-31:

review: Needs Fixing

Revision history for this message

Mario Splivalo (mariosplivalo) wrote on 2015-03-31:

> bzr merge lp:~mariosplivalo/charms/trusty/percona-cluster/enable-binlogs
> ...
> Text conflict in hooks/charmhelpers/contrib/database/mysql.py
> 1 conflicts encountered.

I belive this is because of the prerequisite branch that needs merging first.

Revision history for this message

Mario Splivalo (mariosplivalo) wrote on 2015-07-24:

Based on discussion with Ed, this will be changed in a manner so that a new function is introduced, 'configure_binlogs'. That one will be called from install hook, after mysql has been installed, and will restart mysql for the change to take place.
It will also be called from config_changed hook, but it won't restart mysql - it will log a WARNING inside logs to tell administrator/operator to manually restart mysql when appropriate.

lp://qastaging/~mariosplivalo/charms/trusty/percona-cluster/enable-binlogs updated on 2015-12-03

59. By Mario Splivalo on 2015-10-16: Isolate creation of binlog directory into a separate function
60. By Mario Splivalo on 2015-10-18: Merged /next
61. By Mario Splivalo on 2015-12-03: Conflicts resolved (work from another workstation)

Unmerged revisions

61. By Mario Splivalo on 2015-12-03: Conflicts resolved (work from another workstation)
60. By Mario Splivalo on 2015-10-18: Merged /next
59. By Mario Splivalo on 2015-10-16: Isolate creation of binlog directory into a separate function
58. By Mario Splivalo on 2015-10-09: Merged from /next
57. By Mario Splivalo on 2015-03-12: Fixed typos, as suggested by freyes
56. By Mario Splivalo on 2015-03-12: Fix lint errors
55. By Mario Splivalo on 2015-03-06: Remove call to lchownr as it won't change owner of the base directory.
Instead, use os.chown.
54. By Mario Splivalo on 2015-03-06: Fix directory creation
53. By Mario Splivalo on 2015-03-05: Make sure mysql can start even when binlog_path is pointing to
nonexistant path
52. By Mario Splivalo on 2015-03-04: Create binlog_directory, if missing