Merge lp://qastaging/~mariosplivalo/charms/trusty/percona-cluster/table-cache into lp://qastaging/~openstack-charmers-archive/charms/trusty/percona-cluster/next

Proposed by Mario Splivalo
Status: Merged
Merged at revision: 47
Proposed branch: lp://qastaging/~mariosplivalo/charms/trusty/percona-cluster/table-cache
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/percona-cluster/next
Diff against target: 45 lines (+7/-3)
3 files modified
config.yaml (+5/-0)
hooks/percona_hooks.py (+1/-2)
templates/my.cnf (+1/-1)
To merge this branch: bzr merge lp://qastaging/~mariosplivalo/charms/trusty/percona-cluster/table-cache
Reviewer Review Type Date Requested Status
Billy Olsen Approve
Edward Hope-Morley Pending
Review via email: mp+249829@code.qastaging.launchpad.net

Description of the change

This MP adds the table-open-cache charm config option so that sysadmin deploying the charm can tune table_open_cache mysql variable (formerly known as table_cache - both options are accepted in 5.5).

Also, it raises the default for table_open_cache from 512 to 2048 - this is a sane default as there is no significant increased memory usage with larger table_open_cache, and most deploys would benefit from having larger table cache.

To post a comment you must log in.
Revision history for this message
Billy Olsen (billy-olsen) wrote :

Mario, looks good to me - thanks for the submission. Approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches