Merge lp://qastaging/~markellmtthw/marlin/fix-917023 into lp://qastaging/marlin/0.x

Proposed by Matthew Markell
Status: Merged
Merged at revision: 796
Proposed branch: lp://qastaging/~markellmtthw/marlin/fix-917023
Merge into: lp://qastaging/marlin/0.x
Diff against target: 21 lines (+2/-2)
1 file modified
data/marlin.desktop.in (+2/-2)
To merge this branch: bzr merge lp://qastaging/~markellmtthw/marlin/fix-917023
Reviewer Review Type Date Requested Status
xapantu Approve
Cassidy James Blaede (community) Approve
Review via email: mp+88805@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

I'm not seeing a GenericName, which should be "File Manager" in this case. Also, yeah, I'm not sure about how translations work... marking as needs info for now.

review: Needs Information
Revision history for this message
Matthew Markell (markellmtthw) wrote :

The GenericName is in there and it is File Manager. I talked to victored
about the translations and he says that for this file, Launchpad is
setup to automatically translate this based on the English text.

On 01/16/2012 10:27 PM, Cassidy James wrote:
> Review: Needs Information
>
> I'm not seeing a GenericName, which should be "File Manager" in this case. Also, yeah, I'm not sure about how translations work... marking as needs info for now.

Revision history for this message
Matthew Markell (markellmtthw) wrote :

The reason the GenericName is not in the diff is because it was already File Manager, I didn't change it ;)

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Ah, makes sense.

review: Approve
Revision history for this message
xapantu (xapantu) wrote :

It's ok for me :)

ammonkey: tell me if there is any problem (I'll probably merge it tonight) ;)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: