Merge lp://qastaging/~mars/tarmac/contributor-instructions into lp://qastaging/tarmac

Proposed by Māris Fogels
Status: Merged
Approved by: Paul Hummer
Approved revision: 382
Merged at revision: 383
Proposed branch: lp://qastaging/~mars/tarmac/contributor-instructions
Merge into: lp://qastaging/tarmac
Diff against target: 32 lines (+25/-0)
1 file modified
HACKING (+25/-0)
To merge this branch: bzr merge lp://qastaging/~mars/tarmac/contributor-instructions
Reviewer Review Type Date Requested Status
dobey Approve
Paul Hummer Approve
Review via email: mp+39668@code.qastaging.launchpad.net

Commit message

Added instructions for submitting a Tarmac patch to the HACKING file

Description of the change

Hi,

This branch adds instructions for submitting a Tarmac patch to the to the HACKING file.

If you see anything missing, please let me know!

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
dobey (dobey) wrote :

Actually, item #6 is probably ok to remove from here. As rockstar is the only one who can actually mark the proposals as Approved, since he is the branch owner.

review: Needs Fixing
Revision history for this message
Paul Hummer (rockstar) wrote :

Hi Maris. Thanks for taking the time to note this in the HACKING document. Sometimes I forget that those processes need documentation too.

I think a better solution for this would be to link to Launchpad's help documentation on merge proposals. Mentioning "bzr send" at all is a huge mistake, because it's a pretty advanced method, and one that I don't even use (especially with lp-propose now anyway). Leveraging Launchpad's documentation means that it only gets out of date in one place, instead of two. :)

382. By Māris Fogels

Updated the hacking instructions based on reviewer feedback - draft number 2

Revision history for this message
Māris Fogels (mars) wrote :

Here are some updated instructions - I left in the first three about committing and pushing code, linked to the Launchpad help docs for creating the merge proposal and reviewing the code, and changed the last step to be a bit more descriptive and hopefully helpful.

To get your patch into the Tarmac mainline, do the following:

1. Check your changes into a bzr branch of lp:tarmac

2. Push your changes: ``bzr push lp:~myuser/tarmac/my-descriptive-patch``

3. Follow the Launchpad help instructions to create a new merge proposal
   containing your changes: https://help.launchpad.net/Code/Review

4. The Tarmac core developers will review your code and provide feedback.
   When your code is approved they will commit it for you.

Revision history for this message
Paul Hummer (rockstar) :
review: Approve
Revision history for this message
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches