Merge lp://qastaging/~mars/tarmac/more-logging into lp://qastaging/tarmac
| Status: | Merged |
|---|---|
| Approved by: | Paul Hummer |
| Approved revision: | 382 |
| Merged at revision: | 380 |
| Proposed branch: | lp://qastaging/~mars/tarmac/more-logging |
| Merge into: | lp://qastaging/tarmac |
| Diff against target: |
74 lines (+38/-3) 1 file modified
tarmac/bin/commands.py (+38/-3) |
| To merge this branch: | bzr merge lp://qastaging/~mars/tarmac/more-logging |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paul Hummer | Approve | ||
|
Review via email:
|
|||
Commit message
Added additional debug logging to the authenticate and merge commands.
Description of the change
Hi,
This branch adds additional debug logging to the authenticate and merge commands.
With this patch users can run the 'tarmac merge --debug' command to see what the
program decides to do with the branches it finds, and why it decided to do it.
This solves a problem where new users may not understand why Tarmac is not
finding their branches. They later discover that the program silently skipped
their branches because the Launchpad commit message was not set. (This has
happened to me twice now, on two different Tarmac setups.)
I added the authentication logging to solve a problem with launchpadlib on
headless servers: the 'tarmac authenticate' command was not writing any log
output, and the launchpadlib commands were also failing - I did not know what
the program was doing. The additional logging makes it a bit easier to
understand that the call to launchpadlib is the problem.
This looks great. I'm actually wanting to move in a direction similar to what you did with _get_mergable_