Merge lp://qastaging/~mattyw/charm-helpers/open-close-ports into lp://qastaging/charm-helpers

Proposed by Matthew Williams
Status: Merged
Merged at revision: 671
Proposed branch: lp://qastaging/~mattyw/charm-helpers/open-close-ports
Merge into: lp://qastaging/charm-helpers
Diff against target: 59 lines (+38/-0)
2 files modified
charmhelpers/core/hookenv.py (+14/-0)
tests/core/test_hookenv.py (+24/-0)
To merge this branch: bzr merge lp://qastaging/~mattyw/charm-helpers/open-close-ports
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
Review via email: mp+313437@code.qastaging.launchpad.net

Commit message

hookenv: Added support for opening and closing port ranges with open_ports() and close_ports()

Description of the change

hookenv: Added support for opening and closing port ranges with open_ports() and close_ports()

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) wrote :

Looks good. Tests pass.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches