Merge lp://qastaging/~matzipan/capnet-assist/fix-on-no-network into lp://qastaging/~elementary-apps/capnet-assist/trunk
Proposed by
Zisu Andrei
Status: | Needs review |
---|---|
Proposed branch: | lp://qastaging/~matzipan/capnet-assist/fix-on-no-network |
Merge into: | lp://qastaging/~elementary-apps/capnet-assist/trunk |
Diff against target: |
15 lines (+0/-6) 1 file modified
src/Application.vala (+0/-6) |
To merge this branch: | bzr merge lp://qastaging/~matzipan/capnet-assist/fix-on-no-network |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
elementary Apps team | Pending | ||
Review via email: mp+313646@code.qastaging.launchpad.net |
Description of the change
This code is logically broken. With it, in all cases when a connection is faulty, the method will return true (which means it detected a captive portal). Which would give a lot of false positives.
On faulty internet connections, this code will cause the capnet to pop up for a split second before closing again.
To post a comment you must log in.
Unmerged revisions
- 125. By Zisu Andrei
-
Fix capnet popping up when no network connection is available
Shouldn't it return false then ?