Merge lp://qastaging/~maxb/bzr-cvsps-import/path-gen-fixup into lp://qastaging/bzr-cvsps-import
Proposed by
Max Bowsher
| Status: | Merged |
|---|---|
| Approved by: | John A Meinel |
| Approved revision: | 65 |
| Merged at revision: | 65 |
| Proposed branch: | lp://qastaging/~maxb/bzr-cvsps-import/path-gen-fixup |
| Merge into: | lp://qastaging/bzr-cvsps-import |
| Diff against target: |
18 lines (+2/-2) 1 file modified
cvsps/importer.py (+2/-2) |
| To merge this branch: | bzr merge lp://qastaging/~maxb/bzr-cvsps-import/path-gen-fixup |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| John A Meinel | Approve | ||
| Jelmer Vernooij (community) | code | Approve | |
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Jelmer Vernooij (jelmer) | # |
review:
Approve
(code)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
It would be nice if you could include a bit of coverletter with your
merge proposals, so that we can understand the context.
- From what I can tell, you are just changing the "." => "" earlier in
the code, which seems fine with me, as long as things still work
correctly.
merge: approve
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAk1
73oAnRD+
=nArK
-----END PGP SIGNATURE-----