Merge lp://qastaging/~maxb/bzr-cvsps-import/timezone into lp://qastaging/bzr-cvsps-import

Proposed by Max Bowsher
Status: Merged
Approved by: John A Meinel
Approved revision: 66
Merged at revision: 66
Proposed branch: lp://qastaging/~maxb/bzr-cvsps-import/timezone
Merge into: lp://qastaging/bzr-cvsps-import
Prerequisite: lp://qastaging/~maxb/bzr-cvsps-import/path-gen-fixup
Diff against target: 107 lines (+11/-11)
2 files modified
cvsps/parser.py (+2/-2)
test_cvsps_parser.py (+9/-9)
To merge this branch: bzr merge lp://qastaging/~maxb/bzr-cvsps-import/timezone
Reviewer Review Type Date Requested Status
John A Meinel Approve
Jelmer Vernooij (community) code Approve
Review via email: mp+51048@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) :
review: Approve (code)
Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2/23/2011 6:24 PM, Max Bowsher wrote:
> Max Bowsher has proposed merging lp:~maxb/bzr-cvsps-import/timezone into lp:bzr-cvsps-import with lp:~maxb/bzr-cvsps-import/path-gen-fixup as a prerequisite.
>
> Requested reviews:
> Bazaar Developers (bzr)
>
> For more details, see:
> https://code.launchpad.net/~maxb/bzr-cvsps-import/timezone/+merge/51048

If I understand this, it is just about making sure the times are
timezone independent. Which seems fine to me.

 merge: approve

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1mloYACgkQJdeBCYSNAAN7HgCeKHcfgcixG9hp1EdTB+D104Mp
ZnQAn1uyvXQZDugbWGOYCDEL4DAnlj0n
=rdhk
-----END PGP SIGNATURE-----

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: