Juju Charms Collection
pubphoto package

Merge lp://qastaging/~mbruzek/charms/precise/pubphoto/trunk into lp://qastaging/~jose/charms/precise/pubphoto/trunk

  1. Precise Pangolin (12.04)
  2. trunk
  3. Merge into trunk
Proposed by Matt Bruzek
Status: Merged
Merged at revision: 5
Proposed branch: lp://qastaging/~mbruzek/charms/precise/pubphoto/trunk
Merge into: lp://qastaging/~jose/charms/precise/pubphoto/trunk
Diff against target: 41 lines (+6/-6)
1 file modified
README.md (+6/-6)
To merge this branch: bzr merge lp://qastaging/~mbruzek/charms/precise/pubphoto/trunk
Reviewer Review Type Date Requested Status
José Antonio Rey Approve
Review via email: mp+242944@code.qastaging.launchpad.net

Description of the change

Jose,

I was looking at pubphoto and I made some improvements to the README. Please consider these changes.

Also I have been notified that the Chris Lea got hired by nodesource and node.js install has changed. I believe the install hook will works for precise but you might want to explore alternate installs of node.js so it would be an easier transition to trusty.

https://gist.github.com/marcoceppi/d8143918b7ab7667aa85

wget -qO- https://deb.nodesource.com/gpgkey/nodesource.gpg.key | sudo apt-key add -

echo "deb https://deb.nodesource.com/node $(lsb_release -cs) main" | sudo tee /etc/apt/sources.list.d/nodesource.list
echo "deb-src https://deb.nodesource.com/node $(lsb_release -cs) main" | sudo tee -a /etc/apt/sources.list.d/nodesource.list

sudo apt-get update
sudo apt-get install nodejs

To post a comment you must log in.
Revision history for this message
Matt Bruzek (mbruzek) wrote :

When looking at pubphoto on github (https://github.com/stuartlangridge/pubphoto) I see two names for the project, pubphoto is in the URL but soonsnap (http://soonsnap.com) is referenced. If they are changing the name we should get this sorted before adding to the charm store.

Revision history for this message
José Antonio Rey (jose) wrote :

Hey Matt,

According to sil, the webpage is named soonsnap, but the service is called pubphoto.

Will review later today.

Revision history for this message
José Antonio Rey (jose) wrote :

+1 LGTM

Thanks, Matt! :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: