Juju Charms Collection
rabbitmq-server package

Merge lp://qastaging/~mbruzek/charms/precise/rabbitmq-server/add-tests into lp://qastaging/charms/rabbitmq-server

Proposed by Matt Bruzek on 2015-01-09

Status:	Merged
Merged at revision:	74
Proposed branch:	lp://qastaging/~mbruzek/charms/precise/rabbitmq-server/add-tests
Merge into:	lp://qastaging/charms/rabbitmq-server
Diff against target:	657 lines (+605/-1) 9 files modified Makefile (+5/-1) tests/00_setup.sh (+16/-0) tests/10_basic_deploy_test.py (+101/-0) tests/20_deploy_relations_test.py (+214/-0) tests/30_configuration_test.py (+142/-0) tests/amqp_tester.py (+65/-0) tests/rabbit-server-cacert.pem (+17/-0) tests/rabbit-server-cert.pem (+18/-0) tests/rabbit-server-privkey.pem (+27/-0)
To merge this branch:	bzr merge lp://qastaging/~mbruzek/charms/precise/rabbitmq-server/add-tests
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Review Queue (community)	automated testing		Needs Fixing on 2015-01-12
José Antonio Rey (community)	charmers	2015-01-09	Approve on 2015-01-12
Ryan Beisner (community)			Approve on 2015-01-12
Review via email: mp+246025@code.qastaging.launchpad.net

Description of the change

Adding tests for the rabbitmq-server charm.

Revision history for this message

Ryan Beisner (1chb1n) wrote on 2015-01-10:

Thank you for the amulet test coverage work on rmq, much appreciated!

If we can get this added to Makefile, that will make OSCI's engine happy:

test:
@echo Starting amulet tests...
@juju test -v -p AMULET_HTTP_PROXY --timeout 900

I just sent your branch with ^ that mod through to confirm:
  juju-test.conductor.00_setup.sh RESULT : ✔
  juju-test.conductor.10_basic_deploy_test.py RESULT : ✔
  juju-test.conductor.20_deploy_relations_test.py RESULT : ✔
  juju-test.conductor.30_configuration_test.py RESULT : ✔
  juju-test INFO : Results: 4 passed, 0 failed, 0 errored

I think most of the openstack charms use the 'test' target name. But actually, you can name the make target anything as OSCI just looks for '@juju test' in a target and runs that target.

lp://qastaging/~mbruzek/charms/precise/rabbitmq-server/add-tests updated on 2015-01-12

76. By Matt Bruzek on 2015-01-12: Adding Makefile changes

Revision history for this message

Matt Bruzek (mbruzek) wrote on 2015-01-12:

Thanks for the review. I added the functional_test target to the Makefile so these tests work on both testing systems. Charmers please review these changes for inclusion to the precise charm.

Revision history for this message

Ryan Beisner (1chb1n) wrote on 2015-01-12:

Re-confirmed with rev76. Precise charm amulet tests succeed. Clear from the OSCI perspective. Thanks again!

review: Approve

Revision history for this message

José Antonio Rey (jose) wrote on 2015-01-12:

Hey Matt!

Thank you for taking the time to write this tests. I have ran them on EC2, and turns out they successfully pass!

I will be pushing these on the next few minutes. Thanks again!

review: Approve (charmers)

Revision history for this message

Review Queue (review-queue) wrote on 2015-01-12: