Merge lp://qastaging/~mbruzek/charms/precise/solr-jetty/add-tests into lp://qastaging/~charmers/charms/precise/solr-jetty/trunk

Proposed by Matt Bruzek
Status: Merged
Merged at revision: 19
Proposed branch: lp://qastaging/~mbruzek/charms/precise/solr-jetty/add-tests
Merge into: lp://qastaging/~charmers/charms/precise/solr-jetty/trunk
Diff against target: 109 lines (+64/-0)
4 files modified
config.yaml (+4/-0)
metadata.yaml (+2/-0)
tests/00-setup (+5/-0)
tests/99-autogen (+53/-0)
To merge this branch: bzr merge lp://qastaging/~mbruzek/charms/precise/solr-jetty/add-tests
Reviewer Review Type Date Requested Status
José Antonio Rey (community) Approve
Review Queue (community) automated testing Needs Fixing
Review via email: mp+244367@code.qastaging.launchpad.net

Description of the change

Adding tests and fixing charm proof for solr-jetty charm.

To post a comment you must log in.
Revision history for this message
Matt Bruzek (mbruzek) wrote :

It does not appear that the solr-jetty charm deploys successfully any longer. I opened a separate bug against that here: https://bugs.launchpad.net/charms/+source/solr-jetty/+bug/1401319

We still may want to check in these changes so solr-jetty passes charm proof and has a deployment test that we can later refer to.

Revision history for this message
Review Queue (review-queue) wrote :

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-10687-results

review: Needs Fixing (automated testing)
Revision history for this message
José Antonio Rey (jose) wrote :

A bug has already been filed for the install hook failure, and tests work as expected.

+1 LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: