Merge into 0.9.8 : compiz.fix1030473-part1 : Code : Compiz

Reviewer	Date Requested	Status
Daniel van Vugt	2012-07-29	Approve on 2012-08-03
MC Return		Needs Resubmitting on 2012-07-31
Sam Spilsbury		Approve on 2012-07-30
Review via email: mp+117182@code.qastaging.launchpad.net

Revision history for this message

MC Return (mc-return) wrote on 2012-07-29:

#

Still a lot to do :)

[/compizconfig/compizconfig-python/compizconfig.c:619]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:652]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:818]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1335]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1343]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1354]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1362]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1370]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1378]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1398]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1431]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1475]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1508]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1532]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1570]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:2007]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:2057]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:2722]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:3047]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:3136]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:3630]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:3648]: (style) The second of the two stateme...

Still a lot to do :)

[/compizconfig/compizconfig-python/compizconfig.c:619]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:652]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:818]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1335]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1343]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1354]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1362]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1370]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1378]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1398]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1431]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1475]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1508]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1532]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1570]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:2007]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:2057]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:2722]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:3047]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:3136]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:3630]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:3648]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:3699]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:3847]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:4680]: (style) The second of the two statements can never be executed, and so should be removed.
[/compizconfig/compizconfig-python/compizconfig.c:1131]: (style) The scope of the variable '__pyx_4' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[/compizconfig/compizconfig-python/compizconfig.c:1133]: (style) The scope of the variable '__pyx_6' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[/compizconfig/compizconfig-python/compizconfig.c:3685]: (style) The scope of the variable '__pyx_6' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[/compizconfig/compizconfig-python/compizconfig.c:3832]: (style) The scope of the variable '__pyx_7' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[/compizconfig/compizconfig-python/compizconfig.c:5212]: (style) The scope of the variable '__pyx_3' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[/compizconfig/compizconfig-python/compizconfig.c:6252]: (style) The scope of the variable 'e' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[/compizconfig/compizconfig-python/compizconfig.c:6430]: (style) The scope of the variable 'e' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[/compizconfig/compizconfig-python/compizconfig.c:6609]: (style) The scope of the variable 'e' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[/compizconfig/compizconfig-python/compizconfig.c:155]: (style) struct or union member '__pyx_t_12compizconfig_CCSSettingColorValue::array' is never used
[../compiz.fix1030473-part1/cmake/src/compiz/compiz_discover_gtest_tests.cpp:46]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/cmake/src/compiz/compiz_discover_gtest_tests.cpp:49]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/compizconfig/gconf/src/gconf.c:479]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/compizconfig/gconf/src/gconf.c:1930]: (error) Memory pointed to by 'pathName' is freed twice.
[../compiz.fix1030473-part1/compizconfig/gsettings/gsettings_backend_shared/gsettings_util.c:184]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/compizconfig/gsettings/src/gsettings.c:296]: (warning) Casting between double* and float* which have an incompatible binary data representation
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/backend/src/ini.c:686]: (error) Memory pointed to by 'filePath' is freed twice.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/backend/src/ini.c:187]: (error) Common realloc mistake: 'privData' nulled but not freed upon failure
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/backend/src/ini.c:221]: (error) Common realloc mistake: 'privData' nulled but not freed upon failure
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/bindings.c:380]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/compiz.cpp:3039]: (warning) sscanf %s in format string (no. 1) does not specify a width, use %1023s to prevent overflowing destination: name[1024]
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/compiz.cpp:3039]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/compiz.cpp:2705]: (error) Memory leak: pbFile
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/compiz.cpp:2771]: (error) Memory leak: pbFile
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/compiz.cpp:768]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/filewatch.c:113]: (error) Common realloc mistake: 'fwData' nulled but not freed upon failure
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/filewatch.c:173]: (error) Common realloc mistake: 'fwData' nulled but not freed upon failure
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/ini.c:791]: (error) Common realloc mistake: 'stringBuffer' nulled but not freed upon failure
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/iniparser.c:123]: (style) Defensive programming: The variable i is used as array index and then there is a check that it is within limits. This can mean that the array might be accessed out-of-bounds. Reorder conditions such as '(a[i] && i < 10)' to '(i < 10 && a[i])'. That way the array will not be accessed when the index is out of limits.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:656]: (error) Possible null pointer dereference: subGroup - otherwise it is redundant to check if subGroup is null at line 657
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:3213]: (error) Possible null pointer dereference: conflict - otherwise it is redundant to check if conflict is null at line 3214
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:4305]: (error) Read and write operations without a call to a positioning function (fseek, fsetpos or rewind) or fflush inbetween result in undefined behaviour.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:259]: (error) Memory pointed to by 'val' is freed twice.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:267]: (error) Memory pointed to by 'val' is freed twice.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:275]: (error) Memory pointed to by 'val' is freed twice.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:1037]: (error) Memory pointed to by 'dlname' is freed twice.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:3485]: (error) Memory pointed to by 'backenddir' is freed twice.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:3495]: (error) Memory pointed to by 'backenddir' is freed twice.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:3626]: (error) Memory leak: sectionName
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:3784]: (error) Memory leak: sectionName
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:4262]: (error) Memory leak: completedUpgrades
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:4266]: (error) Memory leak: completedUpgrades
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:4262]: (error) Resource leak: completedUpgrades
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:94]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:100]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:106]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:112]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:118]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:124]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:130]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:136]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:142]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:148]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:154]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:160]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:166]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:172]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:178]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:187]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:196]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:205]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:211]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:217]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:223]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:232]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:241]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:250]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:259]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:265]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:271]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:280]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:289]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:295]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:304]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:313]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:322]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:331]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/context-mock.cpp:68]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:64]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:69]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:74]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:79]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:84]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:89]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:94]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:99]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:104]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:109]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:114]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:119]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:124]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:129]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:134]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:139]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:148]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:154]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:159]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/plugin-mock.cpp:55]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:119]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:125]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:131]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:137]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:143]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:149]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:155]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:161]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:167]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:173]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:179]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:186]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:193]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:200]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:207]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:214]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:221]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:228]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:235]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:242]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:249]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:256]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:263]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:268]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:273]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:278]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:283]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:289]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:294]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:299]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:304]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:309]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:314]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:319]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:324]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:329]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:334]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:339]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:344]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:349]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/setting-mock.cpp:77]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-ccs-object.cpp:86]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-ccs-object.cpp:100]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-ccs-object.cpp:120]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-ccs-object.cpp:129]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-ccs-object.cpp:146]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-ccs-object.cpp:180]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-ccs-object.cpp:192]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-ccs-object.cpp:299]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-ccs-object.cpp:327]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-context.cpp:19]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-plugin.cpp:19]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-setting.cpp:19]: (style) C-style pointer casting
[../compiz.fix1030473-part1/gtk/window-decorator/cairo.c:732] -> [../compiz.fix1030473-part1/gtk/window-decorator/cairo.c:732]: (style) Finding the same expression on both sides of an operator is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct.
[../compiz.fix1030473-part1/gtk/window-decorator/decorator.c:1016]: (error) Memory leak: opts
[../compiz.fix1030473-part1/gtk/window-decorator/events.c:443]: (style) The scope of the variable 'last_button_num' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/gtk/window-decorator/events.c:446]: (style) The scope of the variable 'last_button_x' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/gtk/window-decorator/events.c:447]: (style) The scope of the variable 'last_button_y' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:266]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:269]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:272]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:275]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:278]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:281]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:284]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:287]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:290]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:293]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/metacity.c:599]: (style) Variable 'frame_style' is assigned a value that is never used
[../compiz.fix1030473-part1/kde/window-decorator-kde4/switcher.cpp:227]: (style) Variable 'frameType' is assigned a value that is never used
[../compiz.fix1030473-part1/kde/window-decorator-kde4/switcher.cpp:227]: (style) Variable 'frameState' is assigned a value that is never used
[../compiz.fix1030473-part1/kde/window-decorator-kde4/switcher.cpp:227]: (style) Variable 'frameActions' is assigned a value that is never used
[../compiz.fix1030473-part1/kde/window-decorator-kde4/window.cpp:1153]: (style) The scope of the variable 'nQuad' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/libdecoration/decoration.c:3140]: (style) The scope of the variable 'icccm_version' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/animation/src/animation.cpp:1270]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/animation/src/animation.cpp:1386]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/animation/src/animation.cpp:2934]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/animation/src/extensionplugin.cpp:436]: (style) Defensive programming: The variable changeEnd is used as array index and then there is a check that it is within limits. This can mean that the array might be accessed out-of-bounds. Reorder conditions such as '(a[i] && i < 10)' to '(i < 10 && a[i])'. That way the array will not be accessed when the index is out of limits.
[../compiz.fix1030473-part1/plugins/animation/src/extensionplugin.cpp:152]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/animation/src/extensionplugin.cpp:230]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/animation/src/extensionplugin.cpp:277]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/animation/src/glide.cpp:41]: (warning) Member variable 'GlideAnim::glideModRotAngle' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/animation/src/magiclamp.cpp:55]: (warning) Member variable 'MagicLampAnim::mTopLeftCornerObject' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/animation/src/magiclamp.cpp:55]: (warning) Member variable 'MagicLampAnim::mBottomLeftCornerObject' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/animation/src/options.cpp:127]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/plugins/animation/src/options.cpp:169]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/plugins/animation/src/options.cpp:224]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/plugins/animation/src/options.cpp:231]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/plugins/animation/src/options.cpp:247]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/plugins/animationaddon/src/airplane.cpp:127]: (style) C-style pointer casting
[../compiz.fix1030473-part1/plugins/animationaddon/src/airplane.cpp:348]: (style) C-style pointer casting
[../compiz.fix1030473-part1/plugins/animationaddon/src/airplane.cpp:533]: (style) C-style pointer casting
[../compiz.fix1030473-part1/plugins/animationaddon/src/airplane.cpp:697]: (style) C-style pointer casting
[../compiz.fix1030473-part1/plugins/animationaddon/src/airplane.cpp:747]: (style) C-style pointer casting
[../compiz.fix1030473-part1/plugins/animationaddon/src/private.h:41]: (warning) Member variable 'ExtensionPluginAnimAddon::mOutput' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/animationaddon/src/polygon.cpp:459]: (style) Suspicious calculation. Please use parentheses to clarify the code. The code 'a%b?c:d' should be written as either '(a%b)?c:d' or 'a%(b?c:d)'.
[../compiz.fix1030473-part1/plugins/annotate/src/annotate.cpp:782]: (style) The scope of the variable 'clearColor' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/ccp/src/ccp.cpp:196]: (style) The scope of the variable 'i' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/clone/src/clone.cpp:379]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/clone/src/clone.cpp:536]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/colorfilter/src/colorfilter.cpp:252]: (error) Possible null pointer dereference: func - otherwise it is redundant to check if func is null at line 255
[../compiz.fix1030473-part1/plugins/colorfilter/src/parser.h:34]: (style) The class 'FragmentParser 'does not have a constructor but it has attributes. The attributes are not initialized which may cause bugs or undefined behavior.
[../compiz.fix1030473-part1/plugins/colorfilter/src/colorfilter.cpp:301]: (performance) Checking for 'filtersFunctions' emptiness might be inefficient. Using filtersFunctions.empty() instead of filtersFunctions.size() can be faster. filtersFunctions.size() can take linear time but filtersFunctions.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/colorfilter/src/parser.cpp:152]: (style) The scope of the variable 'temp' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/colorfilter/src/parser.cpp:176]: (style) Suspicious condition (assignment+comparison), it can be clarified with parentheses
[../compiz.fix1030473-part1/plugins/colorfilter/src/parser.cpp:177]: (style) Suspicious condition (assignment+comparison), it can be clarified with parentheses
[../compiz.fix1030473-part1/plugins/colorfilter/src/parser.cpp:438]: (performance) Checking for 'offsets' emptiness might be inefficient. Using offsets.empty() instead of offsets.size() can be faster. offsets.size() can take linear time but offsets.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/compiztoolbox/src/compiztoolbox.cpp:270]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/compiztoolbox/src/compiztoolbox.cpp:281]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::compositeEvent' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::compositeError' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::compositeOpcode' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::damageEvent' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::damageError' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::fixesEvent' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::fixesError' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::fixesVersion' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::shapeExtension' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::shapeEvent' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::shapeError' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::randrExtension' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::randrEvent' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::randrError' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:576]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:773]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:803]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/dbus/src/dbus.cpp:1528]: (performance) Checking for 'path' emptiness might be inefficient. Using path.empty() instead of path.size() can be faster. path.size() can take linear time but path.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/dbus/src/dbus.cpp:214]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/decor/src/clip-groups/tests/clip-groups/src/test-decor-clip-groups.cpp:137]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/decor/src/decor.cpp:612]: (style) The scope of the variable 'left' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/decor/src/decor.cpp:612]: (style) The scope of the variable 'right' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/decor/src/decor.cpp:612]: (style) The scope of the variable 'top' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/decor/src/decor.cpp:612]: (style) The scope of the variable 'bottom' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/decor/src/decor.cpp:581]: (warning) Member variable 'Decoration::refCount' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/decor/src/decor.cpp:1330]: (performance) Checking for 'mList' emptiness might be inefficient. Using mList.empty() instead of mList.size() can be faster. mList.size() can take linear time but mList.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/decor/src/decor.cpp:838]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/decor/src/decor.cpp:887]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/decor/src/decor.cpp:1343]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/extrawm/src/extrawm.cpp:35]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/extrawm/src/extrawm.cpp:93]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/ezoom/src/ezoom.cpp:1483]: (style) The scope of the variable 'x' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/ezoom/src/ezoom.cpp:1483]: (style) The scope of the variable 'y' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/ezoom/src/ezoom.cpp:1795]: (warning) Member variable 'CursorTexture::screen' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/ezoom/src/ezoom.cpp:1795]: (warning) Member variable 'CursorTexture::width' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/ezoom/src/ezoom.cpp:1795]: (warning) Member variable 'CursorTexture::height' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/ezoom/src/ezoom.cpp:1795]: (warning) Member variable 'CursorTexture::hotX' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/ezoom/src/ezoom.cpp:1795]: (warning) Member variable 'CursorTexture::hotY' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/ezoom/src/ezoom.cpp:213]: (warning) Member variable 'ZoomArea::output' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/firepaint/src/firepaint.cpp:456]: (style) The scope of the variable 'size' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/firepaint/src/firepaint.cpp:52]: (warning) Member variable 'ParticleSystem::x' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/firepaint/src/firepaint.cpp:52]: (warning) Member variable 'ParticleSystem::y' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/firepaint/src/firepaint.cpp:57]: (warning) Member variable 'ParticleSystem::x' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/firepaint/src/firepaint.cpp:57]: (warning) Member variable 'ParticleSystem::y' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/firepaint/src/firepaint.cpp:459]: (performance) Checking for 'points' emptiness might be inefficient. Using points.empty() instead of points.size() can be faster. points.size() can take linear time but points.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/firepaint/src/firepaint.cpp:483]: (performance) Checking for 'points' emptiness might be inefficient. Using points.empty() instead of points.size() can be faster. points.size() can take linear time but points.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/grid/src/grid.cpp:635]: (style) The scope of the variable 'check' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/grid/src/grid.h:56]: (warning) Member variable 'GridProps::gravityRight' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/grid/src/grid.h:56]: (warning) Member variable 'GridProps::gravityDown' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/grid/src/grid.h:56]: (warning) Member variable 'GridProps::numCellsX' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/grid/src/grid.h:56]: (warning) Member variable 'GridProps::numCellsY' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/grid/src/grid.cpp:714]: (performance) Checking for 'animations' emptiness might be inefficient. Using animations.empty() instead of animations.size() can be faster. animations.size() can take linear time but animations.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/grid/src/grid.cpp:450]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/grid/src/grid.cpp:935]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/grid/src/grid.cpp:975]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/group.cpp:321]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/init.cpp:121]: (performance) Checking for 'mGroups' emptiness might be inefficient. Using mGroups.empty() instead of mGroups.size() can be faster. mGroups.size() can take linear time but mGroups.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/group/src/init.cpp:231]: (performance) Checking for 'mGroups' emptiness might be inefficient. Using mGroups.empty() instead of mGroups.size() can be faster. mGroups.size() can take linear time but mGroups.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/group/src/init.cpp:140]: (error) Uninitialized variable: group
[../compiz.fix1030473-part1/plugins/group/src/init.cpp:141]: (error) Uninitialized variable: group
[../compiz.fix1030473-part1/plugins/group/src/init.cpp:188]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/init.cpp:301]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/init.cpp:496]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/init.cpp:505]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/paint.cpp:591]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/selection.cpp:123]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/selection.cpp:130]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/selection.cpp:189]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/selection.cpp:320]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/tab.cpp:2946]: (warning) Member variable 'GroupTabBar::mNextDirection' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/group/src/tab.cpp:986]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/tab.cpp:1853]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/tab.cpp:1857]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/loginout/src/loginout.cpp:174]: (style) The scope of the variable 'val2' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/mousepoll/src/mousepoll.cpp:64]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/opacify/src/opacify.cpp:238]: (performance) Checking for 'passive' emptiness might be inefficient. Using passive.empty() instead of passive.size() can be faster. passive.size() can take linear time but passive.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/opengl/src/fragment.cpp:1053]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/opengl/src/paint.cpp:247]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/opengl/src/screen.cpp:659]: (style) The second of the two statements can never be executed, and so should be removed.
[../compiz.fix1030473-part1/plugins/place/src/place.cpp:439]: (style) Suspicious expression. Boolean result is used in bitwise operation. The ! operator and the comparison operators have higher precedence than bitwise operators. It is recommended that the expression is clarified with parentheses.
[../compiz.fix1030473-part1/plugins/place/src/place.cpp:962]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/place/src/screen-size-change/src/screen-size-change.cpp:40]: (style) The scope of the variable 'shiftX' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/place/src/screen-size-change/src/screen-size-change.cpp:40]: (style) The scope of the variable 'shiftY' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/resize/src/resize.cpp:1046]: (style) The scope of the variable 'minWidth' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/resize/src/resize.cpp:1307]: (style) The scope of the variable 'mask' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/ring/src/ring.cpp:454] -> [../compiz.fix1030473-part1/plugins/ring/src/ring.cpp:452]: (style) Finding the same code for an if branch and an else branch is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct.
[../compiz.fix1030473-part1/plugins/ring/src/ring.cpp:224]: (style) The scope of the variable 'pixmap' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/ring/src/ring.cpp:1141]: (performance) Checking for 'mWindows' emptiness might be inefficient. Using mWindows.empty() instead of mWindows.size() can be faster. mWindows.size() can take linear time but mWindows.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/ring/src/ring.cpp:787]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/ring/src/ring.cpp:1119]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/ring/src/ring.cpp:1124]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/ring/src/ring.cpp:1133]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/scale/src/scale.cpp:520]: (performance) Checking for 'slotAreas' emptiness might be inefficient. Using slotAreas.empty() instead of slotAreas.size() can be faster. slotAreas.size() can take linear time but slotAreas.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/scale/src/scale.cpp:773]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/scale/src/scale.cpp:952]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/screenshot/src/screenshot.cpp:125]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/plugins/screenshot/src/screenshot.cpp:203]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/plugins/session/src/session.cpp:203]: (style) The scope of the variable 'num' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/session/src/session.cpp:270]: (style) The scope of the variable 'x' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/session/src/session.cpp:270]: (style) The scope of the variable 'y' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/session/src/session.cpp:270]: (style) The scope of the variable 'width' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/session/src/session.cpp:270]: (style) The scope of the variable 'height' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/session/src/session.cpp:505]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/shift/src/shift.cpp:1165]: (style) The scope of the variable 'color' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/shift/src/shift.cpp:1455]: (style) The scope of the variable 'i' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/shift/src/shift.cpp:826]: (error) Common realloc mistake: 'mWindows' nulled but not freed upon failure
[../compiz.fix1030473-part1/plugins/shift/src/shift.cpp:836]: (error) Common realloc mistake: 'mDrawSlots' nulled but not freed upon failure
[../compiz.fix1030473-part1/plugins/showmouse/src/showmouse.cpp:57]: (warning) Member variable 'ParticleSystem::x' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/showmouse/src/showmouse.cpp:57]: (warning) Member variable 'ParticleSystem::y' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/showmouse/src/showmouse.cpp:62]: (warning) Member variable 'ParticleSystem::x' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/showmouse/src/showmouse.cpp:62]: (warning) Member variable 'ParticleSystem::y' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/snap/src/snap.cpp:204]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/snap/src/snap.cpp:247]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/snap/src/snap.cpp:292]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/snap/src/snap.cpp:333]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/stackswitch/src/stackswitch.cpp:619]: (error) Common realloc mistake: 'mWindows' nulled but not freed upon failure
[../compiz.fix1030473-part1/plugins/stackswitch/src/stackswitch.cpp:624]: (error) Common realloc mistake: 'mDrawSlots' nulled but not freed upon failure
[../compiz.fix1030473-part1/plugins/staticswitcher/src/staticswitcher.cpp:1249]: (warning) Member variable 'StaticSwitchScreen::previewWidth' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/staticswitcher/src/staticswitcher.cpp:1249]: (warning) Member variable 'StaticSwitchScreen::previewHeight' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/staticswitcher/src/staticswitcher.cpp:1249]: (warning) Member variable 'StaticSwitchScreen::previewBorder' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/staticswitcher/src/staticswitcher.cpp:1249]: (warning) Member variable 'StaticSwitchScreen::xCount' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/staticswitcher/src/staticswitcher.cpp:556]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/staticswitcher/src/staticswitcher.cpp:561]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/staticswitcher/src/staticswitcher.cpp:565]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/staticswitcher/src/staticswitcher.cpp:569]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/switcher/src/switcher.cpp:483]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/td/src/3d.cpp:393]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/thumbnail/src/thumbnail.cpp:806]: (performance) Checking for 'damageThumbs' emptiness might be inefficient. Using damageThumbs.empty() instead of damageThumbs.size() can be faster. damageThumbs.size() can take linear time but damageThumbs.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/trailfocus/src/trailfocus.cpp:124]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/trailfocus/src/trailfocus.cpp:155]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::radius' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::rMod' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::duration' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::timer' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::width' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::height' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::adjust' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/wall/src/offset_movement/src/offset-movement.cpp:48]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/wallpaper/src/wallpaper.cpp:373]: (performance) Checking for 'backgroundsPrimary' emptiness might be inefficient. Using backgroundsPrimary.empty() instead of backgroundsPrimary.size() can be faster. backgroundsPrimary.size() can take linear time but backgroundsPrimary.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/wallpaper/src/wallpaper.cpp:574]: (performance) Checking for 'backgroundsPrimary' emptiness might be inefficient. Using backgroundsPrimary.empty() instead of backgroundsPrimary.size() can be faster. backgroundsPrimary.size() can take linear time but backgroundsPrimary.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:37]: (style) The scope of the variable 'v' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:38]: (style) The scope of the variable 's' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:39]: (style) The scope of the variable 'e' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:145]: (style) The scope of the variable 'v' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:146]: (style) The scope of the variable 's' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:147]: (style) The scope of the variable 'e' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:252]: (style) The scope of the variable 'v' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:253]: (style) The scope of the variable 's' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:254]: (style) The scope of the variable 'e' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:359]: (style) The scope of the variable 'v' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:360]: (style) The scope of the variable 's' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:361]: (style) The scope of the variable 'e' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:2144]: (style) The scope of the variable 'i' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:887]: (warning) Member variable 'Model::springs' is not initialized in the constructor.
[../compiz.fix1030473-part1/src/action.cpp:292]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/src/event.cpp:2008]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/match.cpp:394]: (performance) Checking for 'list' emptiness might be inefficient. Using list.empty() instead of list.size() can be faster. list.size() can take linear time but list.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/src/match.cpp:239]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/match.cpp:240]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/plugin.cpp:282]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/plugin.cpp:297]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/plugin.cpp:334]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:2276]: (style) C-style pointer casting
[../compiz.fix1030473-part1/src/screen.cpp:1154]: (style) The scope of the variable 'icccmVersion' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/src/screen.cpp:1091]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container.
[../compiz.fix1030473-part1/src/screen.cpp:2133]: (performance) Checking for 'screenInfo' emptiness might be inefficient. Using screenInfo.empty() instead of screenInfo.size() can be faster. screenInfo.size() can take linear time but screenInfo.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/src/screen.cpp:229]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:336]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:1029]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:2231]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:2941]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:3005]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:3228]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:3372]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:3407]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:3439]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:3455]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:3513]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/stackdebugger.cpp:51]: (warning) Member variable 'StackDebugger::mTimeoutRequired' is not initialized in the constructor.
[../compiz.fix1030473-part1/src/stackdebugger.cpp:84]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/stackdebugger.cpp:108]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/stackdebugger.cpp:156]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/stackdebugger.cpp:252]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/stackdebugger.cpp:255]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/stackdebugger.cpp:338]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/string/tests/printf/src/test-string-printf.cpp:52]: (warning) Member variable 'Value::v' is not initialized in the constructor.
[../compiz.fix1030473-part1/src/timer/src/timeouthandler.cpp:58]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/timer/src/timer.cpp:112]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/timer/src/timer.cpp:155]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/timer/tests/callbacks/src/test-timer-callbacks.cpp:149]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/timer/tests/while-calling/src/test-timer-set-times-while-calling.cpp:53]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/window.cpp:2005]: (error) Analysis failed. If the code is valid then please report this failure.

Revision history for this message

MC Return (mc-return) wrote on 2012-07-29:

#

Download full text (84.3 KiB)

These warnings remain:

[../compiz.fix1030473-part1/cmake/src/compiz/compiz_discover_gtest_tests.cpp:46]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/cmake/src/compiz/compiz_discover_gtest_tests.cpp:49]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/compizconfig/gconf/src/gconf.c:479]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
%s => %20s
%i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/compizconfig/gconf/src/gconf.c:1930]: (error) Memory pointed to by 'pathName' is freed twice.
[../compiz.fix1030473-part1/compizconfig/gsettings/gsettings_backend_shared/gsettings_util.c:184]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
%s => %20s
%i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/compizconfig/gsettings/src/gsettings.c:296]: (warning) Casting between double* and float* which have an incompatible binary data representation
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/backend/src/ini.c:686]: (error) Memory pointed to by 'filePath' is freed twice.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/backend/src/ini.c:187]: (error) Common realloc mistake: 'privData' nulled but not freed upon failure
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/backend/src/ini.c:221]: (error) Common realloc mistake: 'privData' nulled but not freed upon failure
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/bindings.c:380]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
%s => %20s
%i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/compiz.cpp:3039]: (warning) sscanf %s in format string (no. 1) does not specify a width, use %1023s to prevent overflowing destination: name[1024]
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/compiz.cpp:3039]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
%s => %20s
%i => %3i

Sample program that can crash:

#includ...

These warnings remain:

[../compiz.fix1030473-part1/cmake/src/compiz/compiz_discover_gtest_tests.cpp:46]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/cmake/src/compiz/compiz_discover_gtest_tests.cpp:49]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/compizconfig/gconf/src/gconf.c:479]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/compizconfig/gconf/src/gconf.c:1930]: (error) Memory pointed to by 'pathName' is freed twice.
[../compiz.fix1030473-part1/compizconfig/gsettings/gsettings_backend_shared/gsettings_util.c:184]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/compizconfig/gsettings/src/gsettings.c:296]: (warning) Casting between double* and float* which have an incompatible binary data representation
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/backend/src/ini.c:686]: (error) Memory pointed to by 'filePath' is freed twice.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/backend/src/ini.c:187]: (error) Common realloc mistake: 'privData' nulled but not freed upon failure
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/backend/src/ini.c:221]: (error) Common realloc mistake: 'privData' nulled but not freed upon failure
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/bindings.c:380]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/compiz.cpp:3039]: (warning) sscanf %s in format string (no. 1) does not specify a width, use %1023s to prevent overflowing destination: name[1024]
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/compiz.cpp:3039]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/compiz.cpp:2705]: (error) Memory leak: pbFile
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/compiz.cpp:2771]: (error) Memory leak: pbFile
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/compiz.cpp:768]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/filewatch.c:113]: (error) Common realloc mistake: 'fwData' nulled but not freed upon failure
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/filewatch.c:173]: (error) Common realloc mistake: 'fwData' nulled but not freed upon failure
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/ini.c:791]: (error) Common realloc mistake: 'stringBuffer' nulled but not freed upon failure
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/iniparser.c:123]: (style) Defensive programming: The variable i is used as array index and then there is a check that it is within limits. This can mean that the array might be accessed out-of-bounds. Reorder conditions such as '(a[i] && i < 10)' to '(i < 10 && a[i])'. That way the array will not be accessed when the index is out of limits.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:656]: (error) Possible null pointer dereference: subGroup - otherwise it is redundant to check if subGroup is null at line 657
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:3213]: (error) Possible null pointer dereference: conflict - otherwise it is redundant to check if conflict is null at line 3214
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:4305]: (error) Read and write operations without a call to a positioning function (fseek, fsetpos or rewind) or fflush inbetween result in undefined behaviour.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:259]: (error) Memory pointed to by 'val' is freed twice.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:267]: (error) Memory pointed to by 'val' is freed twice.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:275]: (error) Memory pointed to by 'val' is freed twice.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:1037]: (error) Memory pointed to by 'dlname' is freed twice.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:3485]: (error) Memory pointed to by 'backenddir' is freed twice.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:3495]: (error) Memory pointed to by 'backenddir' is freed twice.
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:3626]: (error) Memory leak: sectionName
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:3784]: (error) Memory leak: sectionName
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:4262]: (error) Memory leak: completedUpgrades
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:4266]: (error) Memory leak: completedUpgrades
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/src/main.c:4262]: (error) Resource leak: completedUpgrades
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:94]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:100]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:106]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:112]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:118]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:124]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:130]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:136]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:142]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:148]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:154]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:160]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:166]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:172]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:178]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:187]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:196]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:205]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:211]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:217]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:223]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:232]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:241]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:250]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:259]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:265]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:271]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:280]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:289]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:295]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:304]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:313]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:322]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-context.h:331]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/context-mock.cpp:68]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:64]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:69]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:74]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:79]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:84]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:89]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:94]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:99]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:104]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:109]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:114]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:119]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:124]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:129]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:134]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:139]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:148]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:154]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-plugin.h:159]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/plugin-mock.cpp:55]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:119]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:125]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:131]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:137]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:143]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:149]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:155]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:161]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:167]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:173]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:179]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:186]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:193]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:200]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:207]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:214]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:221]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:228]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:235]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:242]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:249]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:256]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:263]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:268]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:273]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:278]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:283]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:289]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:294]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:299]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:304]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:309]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:314]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:319]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:324]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:329]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:334]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:339]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:344]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/mock-setting.h:349]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/setting-mock.cpp:77]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-ccs-object.cpp:86]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-ccs-object.cpp:100]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-ccs-object.cpp:120]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-ccs-object.cpp:129]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-ccs-object.cpp:146]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-ccs-object.cpp:180]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-ccs-object.cpp:192]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-ccs-object.cpp:299]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-ccs-object.cpp:327]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-context.cpp:19]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-plugin.cpp:19]: (style) C-style pointer casting
[../compiz.fix1030473-part1/compizconfig/libcompizconfig/tests/test-setting.cpp:19]: (style) C-style pointer casting
[../compiz.fix1030473-part1/gtk/window-decorator/cairo.c:732] -> [../compiz.fix1030473-part1/gtk/window-decorator/cairo.c:732]: (style) Finding the same expression on both sides of an operator is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct.
[../compiz.fix1030473-part1/gtk/window-decorator/decorator.c:1016]: (error) Memory leak: opts
[../compiz.fix1030473-part1/gtk/window-decorator/events.c:443]: (style) The scope of the variable 'last_button_num' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/gtk/window-decorator/events.c:446]: (style) The scope of the variable 'last_button_x' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/gtk/window-decorator/events.c:447]: (style) The scope of the variable 'last_button_y' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:266]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:269]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:272]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:275]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:278]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:281]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:284]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:287]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:290]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/frames.c:293]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../compiz.fix1030473-part1/gtk/window-decorator/metacity.c:599]: (style) Variable 'frame_style' is assigned a value that is never used
[../compiz.fix1030473-part1/kde/window-decorator-kde4/switcher.cpp:227]: (style) Variable 'frameType' is assigned a value that is never used
[../compiz.fix1030473-part1/kde/window-decorator-kde4/switcher.cpp:227]: (style) Variable 'frameState' is assigned a value that is never used
[../compiz.fix1030473-part1/kde/window-decorator-kde4/switcher.cpp:227]: (style) Variable 'frameActions' is assigned a value that is never used
[../compiz.fix1030473-part1/kde/window-decorator-kde4/window.cpp:1153]: (style) The scope of the variable 'nQuad' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/libdecoration/decoration.c:3140]: (style) The scope of the variable 'icccm_version' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/animation/src/animation.cpp:1270]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/animation/src/animation.cpp:1386]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/animation/src/animation.cpp:2934]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/animation/src/extensionplugin.cpp:436]: (style) Defensive programming: The variable changeEnd is used as array index and then there is a check that it is within limits. This can mean that the array might be accessed out-of-bounds. Reorder conditions such as '(a[i] && i < 10)' to '(i < 10 && a[i])'. That way the array will not be accessed when the index is out of limits.
[../compiz.fix1030473-part1/plugins/animation/src/extensionplugin.cpp:152]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/animation/src/extensionplugin.cpp:230]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/animation/src/extensionplugin.cpp:277]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/animation/src/glide.cpp:41]: (warning) Member variable 'GlideAnim::glideModRotAngle' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/animation/src/magiclamp.cpp:55]: (warning) Member variable 'MagicLampAnim::mTopLeftCornerObject' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/animation/src/magiclamp.cpp:55]: (warning) Member variable 'MagicLampAnim::mBottomLeftCornerObject' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/animation/src/options.cpp:127]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/plugins/animation/src/options.cpp:169]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/plugins/animation/src/options.cpp:224]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/plugins/animation/src/options.cpp:231]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/plugins/animation/src/options.cpp:247]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/plugins/animationaddon/src/airplane.cpp:127]: (style) C-style pointer casting
[../compiz.fix1030473-part1/plugins/animationaddon/src/airplane.cpp:348]: (style) C-style pointer casting
[../compiz.fix1030473-part1/plugins/animationaddon/src/airplane.cpp:533]: (style) C-style pointer casting
[../compiz.fix1030473-part1/plugins/animationaddon/src/airplane.cpp:697]: (style) C-style pointer casting
[../compiz.fix1030473-part1/plugins/animationaddon/src/airplane.cpp:747]: (style) C-style pointer casting
[../compiz.fix1030473-part1/plugins/animationaddon/src/private.h:41]: (warning) Member variable 'ExtensionPluginAnimAddon::mOutput' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/animationaddon/src/polygon.cpp:459]: (style) Suspicious calculation. Please use parentheses to clarify the code. The code 'a%b?c:d' should be written as either '(a%b)?c:d' or 'a%(b?c:d)'.
[../compiz.fix1030473-part1/plugins/clone/src/clone.cpp:379]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/clone/src/clone.cpp:536]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/colorfilter/src/colorfilter.cpp:252]: (error) Possible null pointer dereference: func - otherwise it is redundant to check if func is null at line 255
[../compiz.fix1030473-part1/plugins/colorfilter/src/parser.h:34]: (style) The class 'FragmentParser 'does not have a constructor but it has attributes. The attributes are not initialized which may cause bugs or undefined behavior.
[../compiz.fix1030473-part1/plugins/colorfilter/src/colorfilter.cpp:301]: (performance) Checking for 'filtersFunctions' emptiness might be inefficient. Using filtersFunctions.empty() instead of filtersFunctions.size() can be faster. filtersFunctions.size() can take linear time but filtersFunctions.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/colorfilter/src/parser.cpp:152]: (style) The scope of the variable 'temp' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/colorfilter/src/parser.cpp:176]: (style) Suspicious condition (assignment+comparison), it can be clarified with parentheses
[../compiz.fix1030473-part1/plugins/colorfilter/src/parser.cpp:177]: (style) Suspicious condition (assignment+comparison), it can be clarified with parentheses
[../compiz.fix1030473-part1/plugins/colorfilter/src/parser.cpp:438]: (performance) Checking for 'offsets' emptiness might be inefficient. Using offsets.empty() instead of offsets.size() can be faster. offsets.size() can take linear time but offsets.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/compiztoolbox/src/compiztoolbox.cpp:270]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/compiztoolbox/src/compiztoolbox.cpp:281]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::compositeEvent' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::compositeError' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::compositeOpcode' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::damageEvent' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::damageError' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::fixesEvent' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::fixesError' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::fixesVersion' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::shapeExtension' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::shapeEvent' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::shapeError' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::randrExtension' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::randrEvent' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::randrError' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:576]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:773]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/composite/src/screen.cpp:803]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/dbus/src/dbus.cpp:1528]: (performance) Checking for 'path' emptiness might be inefficient. Using path.empty() instead of path.size() can be faster. path.size() can take linear time but path.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/dbus/src/dbus.cpp:214]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/decor/src/clip-groups/tests/clip-groups/src/test-decor-clip-groups.cpp:137]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/decor/src/decor.cpp:581]: (warning) Member variable 'Decoration::refCount' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/decor/src/decor.cpp:1326]: (performance) Checking for 'mList' emptiness might be inefficient. Using mList.empty() instead of mList.size() can be faster. mList.size() can take linear time but mList.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/decor/src/decor.cpp:834]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/decor/src/decor.cpp:883]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/decor/src/decor.cpp:1339]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/extrawm/src/extrawm.cpp:35]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/extrawm/src/extrawm.cpp:93]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/ezoom/src/ezoom.cpp:1794]: (warning) Member variable 'CursorTexture::screen' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/ezoom/src/ezoom.cpp:1794]: (warning) Member variable 'CursorTexture::width' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/ezoom/src/ezoom.cpp:1794]: (warning) Member variable 'CursorTexture::height' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/ezoom/src/ezoom.cpp:1794]: (warning) Member variable 'CursorTexture::hotX' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/ezoom/src/ezoom.cpp:1794]: (warning) Member variable 'CursorTexture::hotY' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/ezoom/src/ezoom.cpp:213]: (warning) Member variable 'ZoomArea::output' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/firepaint/src/firepaint.cpp:52]: (warning) Member variable 'ParticleSystem::x' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/firepaint/src/firepaint.cpp:52]: (warning) Member variable 'ParticleSystem::y' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/firepaint/src/firepaint.cpp:57]: (warning) Member variable 'ParticleSystem::x' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/firepaint/src/firepaint.cpp:57]: (warning) Member variable 'ParticleSystem::y' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/firepaint/src/firepaint.cpp:458]: (performance) Checking for 'points' emptiness might be inefficient. Using points.empty() instead of points.size() can be faster. points.size() can take linear time but points.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/firepaint/src/firepaint.cpp:482]: (performance) Checking for 'points' emptiness might be inefficient. Using points.empty() instead of points.size() can be faster. points.size() can take linear time but points.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/grid/src/grid.h:56]: (warning) Member variable 'GridProps::gravityRight' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/grid/src/grid.h:56]: (warning) Member variable 'GridProps::gravityDown' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/grid/src/grid.h:56]: (warning) Member variable 'GridProps::numCellsX' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/grid/src/grid.h:56]: (warning) Member variable 'GridProps::numCellsY' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/grid/src/grid.cpp:714]: (performance) Checking for 'animations' emptiness might be inefficient. Using animations.empty() instead of animations.size() can be faster. animations.size() can take linear time but animations.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/grid/src/grid.cpp:450]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/grid/src/grid.cpp:935]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/grid/src/grid.cpp:975]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/group.cpp:321]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/init.cpp:121]: (performance) Checking for 'mGroups' emptiness might be inefficient. Using mGroups.empty() instead of mGroups.size() can be faster. mGroups.size() can take linear time but mGroups.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/group/src/init.cpp:231]: (performance) Checking for 'mGroups' emptiness might be inefficient. Using mGroups.empty() instead of mGroups.size() can be faster. mGroups.size() can take linear time but mGroups.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/group/src/init.cpp:140]: (error) Uninitialized variable: group
[../compiz.fix1030473-part1/plugins/group/src/init.cpp:141]: (error) Uninitialized variable: group
[../compiz.fix1030473-part1/plugins/group/src/init.cpp:188]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/init.cpp:301]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/init.cpp:496]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/init.cpp:505]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/paint.cpp:591]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/selection.cpp:123]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/selection.cpp:130]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/selection.cpp:189]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/selection.cpp:320]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/tab.cpp:2946]: (warning) Member variable 'GroupTabBar::mNextDirection' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/group/src/tab.cpp:986]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/tab.cpp:1853]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/group/src/tab.cpp:1857]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/mousepoll/src/mousepoll.cpp:64]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/opacify/src/opacify.cpp:238]: (performance) Checking for 'passive' emptiness might be inefficient. Using passive.empty() instead of passive.size() can be faster. passive.size() can take linear time but passive.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/opengl/src/fragment.cpp:1053]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/opengl/src/paint.cpp:247]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/opengl/src/screen.cpp:659]: (style) The second of the two statements can never be executed, and so should be removed.
[../compiz.fix1030473-part1/plugins/place/src/place.cpp:439]: (style) Suspicious expression. Boolean result is used in bitwise operation. The ! operator and the comparison operators have higher precedence than bitwise operators. It is recommended that the expression is clarified with parentheses.
[../compiz.fix1030473-part1/plugins/place/src/place.cpp:962]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/ring/src/ring.cpp:454] -> [../compiz.fix1030473-part1/plugins/ring/src/ring.cpp:452]: (style) Finding the same code for an if branch and an else branch is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct.
[../compiz.fix1030473-part1/plugins/ring/src/ring.cpp:224]: (style) The scope of the variable 'pixmap' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/ring/src/ring.cpp:1141]: (performance) Checking for 'mWindows' emptiness might be inefficient. Using mWindows.empty() instead of mWindows.size() can be faster. mWindows.size() can take linear time but mWindows.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/ring/src/ring.cpp:787]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/ring/src/ring.cpp:1119]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/ring/src/ring.cpp:1124]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/ring/src/ring.cpp:1133]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/scale/src/scale.cpp:520]: (performance) Checking for 'slotAreas' emptiness might be inefficient. Using slotAreas.empty() instead of slotAreas.size() can be faster. slotAreas.size() can take linear time but slotAreas.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/scale/src/scale.cpp:773]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/scale/src/scale.cpp:952]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/screenshot/src/screenshot.cpp:125]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/plugins/screenshot/src/screenshot.cpp:203]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/plugins/session/src/session.cpp:503]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/shift/src/shift.cpp:1455]: (style) The scope of the variable 'i' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/shift/src/shift.cpp:826]: (error) Common realloc mistake: 'mWindows' nulled but not freed upon failure
[../compiz.fix1030473-part1/plugins/shift/src/shift.cpp:836]: (error) Common realloc mistake: 'mDrawSlots' nulled but not freed upon failure
[../compiz.fix1030473-part1/plugins/showmouse/src/showmouse.cpp:57]: (warning) Member variable 'ParticleSystem::x' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/showmouse/src/showmouse.cpp:57]: (warning) Member variable 'ParticleSystem::y' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/showmouse/src/showmouse.cpp:62]: (warning) Member variable 'ParticleSystem::x' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/showmouse/src/showmouse.cpp:62]: (warning) Member variable 'ParticleSystem::y' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/snap/src/snap.cpp:204]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/snap/src/snap.cpp:247]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/snap/src/snap.cpp:292]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/snap/src/snap.cpp:333]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/stackswitch/src/stackswitch.cpp:619]: (error) Common realloc mistake: 'mWindows' nulled but not freed upon failure
[../compiz.fix1030473-part1/plugins/stackswitch/src/stackswitch.cpp:624]: (error) Common realloc mistake: 'mDrawSlots' nulled but not freed upon failure
[../compiz.fix1030473-part1/plugins/staticswitcher/src/staticswitcher.cpp:1249]: (warning) Member variable 'StaticSwitchScreen::previewWidth' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/staticswitcher/src/staticswitcher.cpp:1249]: (warning) Member variable 'StaticSwitchScreen::previewHeight' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/staticswitcher/src/staticswitcher.cpp:1249]: (warning) Member variable 'StaticSwitchScreen::previewBorder' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/staticswitcher/src/staticswitcher.cpp:1249]: (warning) Member variable 'StaticSwitchScreen::xCount' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/staticswitcher/src/staticswitcher.cpp:556]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/staticswitcher/src/staticswitcher.cpp:561]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/staticswitcher/src/staticswitcher.cpp:565]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/staticswitcher/src/staticswitcher.cpp:569]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/switcher/src/switcher.cpp:483]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/td/src/3d.cpp:393]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/thumbnail/src/thumbnail.cpp:806]: (performance) Checking for 'damageThumbs' emptiness might be inefficient. Using damageThumbs.empty() instead of damageThumbs.size() can be faster. damageThumbs.size() can take linear time but damageThumbs.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/trailfocus/src/trailfocus.cpp:124]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/trailfocus/src/trailfocus.cpp:155]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::radius' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::rMod' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::duration' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::timer' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::width' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::height' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::adjust' is not initialized in the constructor.
[../compiz.fix1030473-part1/plugins/wall/src/offset_movement/src/offset-movement.cpp:48]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/plugins/wallpaper/src/wallpaper.cpp:373]: (performance) Checking for 'backgroundsPrimary' emptiness might be inefficient. Using backgroundsPrimary.empty() instead of backgroundsPrimary.size() can be faster. backgroundsPrimary.size() can take linear time but backgroundsPrimary.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/wallpaper/src/wallpaper.cpp:574]: (performance) Checking for 'backgroundsPrimary' emptiness might be inefficient. Using backgroundsPrimary.empty() instead of backgroundsPrimary.size() can be faster. backgroundsPrimary.size() can take linear time but backgroundsPrimary.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:37]: (style) The scope of the variable 'v' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:38]: (style) The scope of the variable 's' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:39]: (style) The scope of the variable 'e' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:145]: (style) The scope of the variable 'v' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:146]: (style) The scope of the variable 's' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:147]: (style) The scope of the variable 'e' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:252]: (style) The scope of the variable 'v' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:253]: (style) The scope of the variable 's' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:254]: (style) The scope of the variable 'e' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:359]: (style) The scope of the variable 'v' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:360]: (style) The scope of the variable 's' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:361]: (style) The scope of the variable 'e' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:2144]: (style) The scope of the variable 'i' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/plugins/wobbly/src/wobbly.cpp:887]: (warning) Member variable 'Model::springs' is not initialized in the constructor.
[../compiz.fix1030473-part1/src/action.cpp:292]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compiz.fix1030473-part1/src/event.cpp:2008]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/match.cpp:394]: (performance) Checking for 'list' emptiness might be inefficient. Using list.empty() instead of list.size() can be faster. list.size() can take linear time but list.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/src/match.cpp:239]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/match.cpp:240]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/plugin.cpp:282]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/plugin.cpp:297]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/plugin.cpp:334]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:2276]: (style) C-style pointer casting
[../compiz.fix1030473-part1/src/screen.cpp:1154]: (style) The scope of the variable 'icccmVersion' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../compiz.fix1030473-part1/src/screen.cpp:1091]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container.
[../compiz.fix1030473-part1/src/screen.cpp:2133]: (performance) Checking for 'screenInfo' emptiness might be inefficient. Using screenInfo.empty() instead of screenInfo.size() can be faster. screenInfo.size() can take linear time but screenInfo.empty() is guaranteed to take constant time.
[../compiz.fix1030473-part1/src/screen.cpp:229]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:336]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:1029]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:2231]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:2941]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:3005]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:3228]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:3372]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:3407]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:3439]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:3455]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/screen.cpp:3513]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/stackdebugger.cpp:51]: (warning) Member variable 'StackDebugger::mTimeoutRequired' is not initialized in the constructor.
[../compiz.fix1030473-part1/src/stackdebugger.cpp:84]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/stackdebugger.cpp:108]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/stackdebugger.cpp:156]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/stackdebugger.cpp:252]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/stackdebugger.cpp:255]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/stackdebugger.cpp:338]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/string/tests/printf/src/test-string-printf.cpp:52]: (warning) Member variable 'Value::v' is not initialized in the constructor.
[../compiz.fix1030473-part1/src/timer/src/timeouthandler.cpp:58]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/timer/src/timer.cpp:112]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/timer/src/timer.cpp:155]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/timer/tests/callbacks/src/test-timer-callbacks.cpp:149]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/timer/tests/while-calling/src/test-timer-set-times-while-calling.cpp:53]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compiz.fix1030473-part1/src/window.cpp:2005]: (error) Analysis failed. If the code is valid then please report this failure.

Revision history for this message

MC Return (mc-return) wrote on 2012-07-29:

#

Download full text (46.5 KiB)

Those problems remain:

[../compizconfig/gconf/src/gconf.c:479]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
%s => %20s
%i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compizconfig/gconf/src/gconf.c:1930]: (error) Memory pointed to by 'pathName' is freed twice.
[../compizconfig/gsettings/gsettings_backend_shared/gsettings_util.c:184]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
%s => %20s
%i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compizconfig/gsettings/src/gsettings.c:296]: (warning) Casting between double* and float* which have an incompatible binary data representation
[../compizconfig/libcompizconfig/backend/src/ini.c:686]: (error) Memory pointed to by 'filePath' is freed twice.
[../compizconfig/libcompizconfig/backend/src/ini.c:187]: (error) Common realloc mistake: 'privData' nulled but not freed upon failure
[../compizconfig/libcompizconfig/backend/src/ini.c:221]: (error) Common realloc mistake: 'privData' nulled but not freed upon failure
[../compizconfig/libcompizconfig/src/bindings.c:380]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
%s => %20s
%i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compizconfig/libcompizconfig/src/compiz.cpp:3039]: (warning) sscanf %s in format string (no. 1) does not specify a width, use %1023s to prevent overflowing destination: name[1024]
[../compizconfig/libcompizconfig/src/compiz.cpp:3039]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
%s => %20s
%i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compizconfig/libcompizconfig/src/compiz.cpp:2705]: (error) Memory leak: pbFile
[../compizconfig/libcompizconfig/src/compiz.cpp:2771]: (error) Memory leak: pbFile
[../compizconfig/libcompizconfig/src/compiz.cpp:768]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compizconfig/libcompizconfig/src/filewatch.c:113]: (error) Common realloc mistake: 'fwData' nulled but not freed upon failure
[../compizconfig/libcompizconfig/src/filewatch.c:173]: (error) Common realloc mistake: 'fwData' nulled but not freed upon failure
[../compizconfig/libcompizconfig/src/ini.c:791]: (error) Common reall...

Those problems remain:

[../compizconfig/gconf/src/gconf.c:479]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compizconfig/gconf/src/gconf.c:1930]: (error) Memory pointed to by 'pathName' is freed twice.
[../compizconfig/gsettings/gsettings_backend_shared/gsettings_util.c:184]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compizconfig/gsettings/src/gsettings.c:296]: (warning) Casting between double* and float* which have an incompatible binary data representation
[../compizconfig/libcompizconfig/backend/src/ini.c:686]: (error) Memory pointed to by 'filePath' is freed twice.
[../compizconfig/libcompizconfig/backend/src/ini.c:187]: (error) Common realloc mistake: 'privData' nulled but not freed upon failure
[../compizconfig/libcompizconfig/backend/src/ini.c:221]: (error) Common realloc mistake: 'privData' nulled but not freed upon failure
[../compizconfig/libcompizconfig/src/bindings.c:380]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compizconfig/libcompizconfig/src/compiz.cpp:3039]: (warning) sscanf %s in format string (no. 1) does not specify a width, use %1023s to prevent overflowing destination: name[1024]
[../compizconfig/libcompizconfig/src/compiz.cpp:3039]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compizconfig/libcompizconfig/src/compiz.cpp:2705]: (error) Memory leak: pbFile
[../compizconfig/libcompizconfig/src/compiz.cpp:2771]: (error) Memory leak: pbFile
[../compizconfig/libcompizconfig/src/compiz.cpp:768]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../compizconfig/libcompizconfig/src/filewatch.c:113]: (error) Common realloc mistake: 'fwData' nulled but not freed upon failure
[../compizconfig/libcompizconfig/src/filewatch.c:173]: (error) Common realloc mistake: 'fwData' nulled but not freed upon failure
[../compizconfig/libcompizconfig/src/ini.c:791]: (error) Common realloc mistake: 'stringBuffer' nulled but not freed upon failure
[../compizconfig/libcompizconfig/src/iniparser.c:123]: (style) Defensive programming: The variable i is used as array index and then there is a check that it is within limits. This can mean that the array might be accessed out-of-bounds. Reorder conditions such as '(a[i] && i < 10)' to '(i < 10 && a[i])'. That way the array will not be accessed when the index is out of limits.
[../compizconfig/libcompizconfig/src/main.c:656]: (error) Possible null pointer dereference: subGroup - otherwise it is redundant to check if subGroup is null at line 657
[../compizconfig/libcompizconfig/src/main.c:3213]: (error) Possible null pointer dereference: conflict - otherwise it is redundant to check if conflict is null at line 3214
[../compizconfig/libcompizconfig/src/main.c:4305]: (error) Read and write operations without a call to a positioning function (fseek, fsetpos or rewind) or fflush inbetween result in undefined behaviour.
[../compizconfig/libcompizconfig/src/main.c:259]: (error) Memory pointed to by 'val' is freed twice.
[../compizconfig/libcompizconfig/src/main.c:267]: (error) Memory pointed to by 'val' is freed twice.
[../compizconfig/libcompizconfig/src/main.c:275]: (error) Memory pointed to by 'val' is freed twice.
[../compizconfig/libcompizconfig/src/main.c:1037]: (error) Memory pointed to by 'dlname' is freed twice.
[../compizconfig/libcompizconfig/src/main.c:3485]: (error) Memory pointed to by 'backenddir' is freed twice.
[../compizconfig/libcompizconfig/src/main.c:3495]: (error) Memory pointed to by 'backenddir' is freed twice.
[../compizconfig/libcompizconfig/src/main.c:3626]: (error) Memory leak: sectionName
[../compizconfig/libcompizconfig/src/main.c:3784]: (error) Memory leak: sectionName
[../compizconfig/libcompizconfig/src/main.c:4262]: (error) Memory leak: completedUpgrades
[../compizconfig/libcompizconfig/src/main.c:4266]: (error) Memory leak: completedUpgrades
[../compizconfig/libcompizconfig/src/main.c:4262]: (error) Resource leak: completedUpgrades
[../compizconfig/libcompizconfig/tests/mock-context.h:94]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:100]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:106]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:112]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:118]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:124]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:130]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:136]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:142]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:148]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:154]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:160]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:166]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:172]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:178]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:187]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:196]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:205]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:211]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:217]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:223]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:232]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:241]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:250]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:259]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:265]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:271]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:280]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:289]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:295]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:304]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:313]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:322]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:331]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/context-mock.cpp:68]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:64]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:69]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:74]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:79]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:84]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:89]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:94]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:99]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:104]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:109]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:114]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:119]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:124]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:129]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:134]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:139]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:148]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:154]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:159]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/plugin-mock.cpp:55]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:119]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:125]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:131]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:137]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:143]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:149]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:155]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:161]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:167]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:173]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:179]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:186]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:193]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:200]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:207]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:214]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:221]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:228]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:235]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:242]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:249]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:256]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:263]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:268]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:273]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:278]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:283]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:289]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:294]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:299]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:304]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:309]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:314]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:319]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:324]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:329]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:334]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:339]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:344]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:349]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/setting-mock.cpp:77]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-ccs-object.cpp:86]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-ccs-object.cpp:100]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-ccs-object.cpp:120]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-ccs-object.cpp:129]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-ccs-object.cpp:146]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-ccs-object.cpp:180]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-ccs-object.cpp:192]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-ccs-object.cpp:299]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-ccs-object.cpp:327]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-context.cpp:19]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-plugin.cpp:19]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-setting.cpp:19]: (style) C-style pointer casting
[../gtk/window-decorator/cairo.c:732] -> [../gtk/window-decorator/cairo.c:732]: (style) Finding the same expression on both sides of an operator is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct.
[../gtk/window-decorator/decorator.c:1016]: (error) Memory leak: opts
[../gtk/window-decorator/frames.c:266]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/frames.c:269]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/frames.c:272]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/frames.c:275]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/frames.c:278]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/frames.c:281]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/frames.c:284]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/frames.c:287]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/frames.c:290]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/frames.c:293]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/metacity.c:599]: (style) Variable 'frame_style' is assigned a value that is never used
[../kde/window-decorator-kde4/switcher.cpp:227]: (style) Variable 'frameType' is assigned a value that is never used
[../kde/window-decorator-kde4/switcher.cpp:227]: (style) Variable 'frameState' is assigned a value that is never used
[../kde/window-decorator-kde4/switcher.cpp:227]: (style) Variable 'frameActions' is assigned a value that is never used
[../kde/window-decorator-kde4/window.cpp:1153]: (style) The scope of the variable 'nQuad' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../libdecoration/decoration.c:3140]: (style) The scope of the variable 'icccm_version' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../plugins/animation/src/extensionplugin.cpp:436]: (style) Defensive programming: The variable changeEnd is used as array index and then there is a check that it is within limits. This can mean that the array might be accessed out-of-bounds. Reorder conditions such as '(a[i] && i < 10)' to '(i < 10 && a[i])'. That way the array will not be accessed when the index is out of limits.
[../plugins/animation/src/glide.cpp:41]: (warning) Member variable 'GlideAnim::glideModRotAngle' is not initialized in the constructor.
[../plugins/animation/src/magiclamp.cpp:55]: (warning) Member variable 'MagicLampAnim::mTopLeftCornerObject' is not initialized in the constructor.
[../plugins/animation/src/magiclamp.cpp:55]: (warning) Member variable 'MagicLampAnim::mBottomLeftCornerObject' is not initialized in the constructor.
[../plugins/animation/src/options.cpp:127]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../plugins/animation/src/options.cpp:169]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../plugins/animation/src/options.cpp:224]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../plugins/animation/src/options.cpp:231]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../plugins/animation/src/options.cpp:247]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../plugins/animationaddon/src/airplane.cpp:127]: (style) C-style pointer casting
[../plugins/animationaddon/src/airplane.cpp:348]: (style) C-style pointer casting
[../plugins/animationaddon/src/airplane.cpp:533]: (style) C-style pointer casting
[../plugins/animationaddon/src/airplane.cpp:697]: (style) C-style pointer casting
[../plugins/animationaddon/src/airplane.cpp:747]: (style) C-style pointer casting
[../plugins/animationaddon/src/private.h:41]: (warning) Member variable 'ExtensionPluginAnimAddon::mOutput' is not initialized in the constructor.
[../plugins/animationaddon/src/polygon.cpp:459]: (style) Suspicious calculation. Please use parentheses to clarify the code. The code 'a%b?c:d' should be written as either '(a%b)?c:d' or 'a%(b?c:d)'.
[../plugins/colorfilter/src/colorfilter.cpp:252]: (error) Possible null pointer dereference: func - otherwise it is redundant to check if func is null at line 255
[../plugins/colorfilter/src/parser.h:34]: (style) The class 'FragmentParser 'does not have a constructor but it has attributes. The attributes are not initialized which may cause bugs or undefined behavior.
[../plugins/colorfilter/src/colorfilter.cpp:301]: (performance) Checking for 'filtersFunctions' emptiness might be inefficient. Using filtersFunctions.empty() instead of filtersFunctions.size() can be faster. filtersFunctions.size() can take linear time but filtersFunctions.empty() is guaranteed to take constant time.
[../plugins/colorfilter/src/parser.cpp:152]: (style) The scope of the variable 'temp' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../plugins/colorfilter/src/parser.cpp:176]: (style) Suspicious condition (assignment+comparison), it can be clarified with parentheses
[../plugins/colorfilter/src/parser.cpp:177]: (style) Suspicious condition (assignment+comparison), it can be clarified with parentheses
[../plugins/colorfilter/src/parser.cpp:438]: (performance) Checking for 'offsets' emptiness might be inefficient. Using offsets.empty() instead of offsets.size() can be faster. offsets.size() can take linear time but offsets.empty() is guaranteed to take constant time.
[../plugins/compiztoolbox/src/compiztoolbox.cpp:270]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::compositeEvent' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::compositeError' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::compositeOpcode' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::damageEvent' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::damageError' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::fixesEvent' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::fixesError' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::fixesVersion' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::shapeExtension' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::shapeEvent' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::shapeError' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::randrExtension' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::randrEvent' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::randrError' is not initialized in the constructor.
[../plugins/dbus/src/dbus.cpp:1528]: (performance) Checking for 'path' emptiness might be inefficient. Using path.empty() instead of path.size() can be faster. path.size() can take linear time but path.empty() is guaranteed to take constant time.
[../plugins/decor/src/clip-groups/tests/clip-groups/src/test-decor-clip-groups.cpp:137]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
[../plugins/decor/src/decor.cpp:581]: (warning) Member variable 'Decoration::refCount' is not initialized in the constructor.
[../plugins/decor/src/decor.cpp:1326]: (performance) Checking for 'mList' emptiness might be inefficient. Using mList.empty() instead of mList.size() can be faster. mList.size() can take linear time but mList.empty() is guaranteed to take constant time.
[../plugins/ezoom/src/ezoom.cpp:1794]: (warning) Member variable 'CursorTexture::screen' is not initialized in the constructor.
[../plugins/ezoom/src/ezoom.cpp:1794]: (warning) Member variable 'CursorTexture::width' is not initialized in the constructor.
[../plugins/ezoom/src/ezoom.cpp:1794]: (warning) Member variable 'CursorTexture::height' is not initialized in the constructor.
[../plugins/ezoom/src/ezoom.cpp:1794]: (warning) Member variable 'CursorTexture::hotX' is not initialized in the constructor.
[../plugins/ezoom/src/ezoom.cpp:1794]: (warning) Member variable 'CursorTexture::hotY' is not initialized in the constructor.
[../plugins/ezoom/src/ezoom.cpp:213]: (warning) Member variable 'ZoomArea::output' is not initialized in the constructor.
[../plugins/firepaint/src/firepaint.cpp:52]: (warning) Member variable 'ParticleSystem::x' is not initialized in the constructor.
[../plugins/firepaint/src/firepaint.cpp:52]: (warning) Member variable 'ParticleSystem::y' is not initialized in the constructor.
[../plugins/firepaint/src/firepaint.cpp:57]: (warning) Member variable 'ParticleSystem::x' is not initialized in the constructor.
[../plugins/firepaint/src/firepaint.cpp:57]: (warning) Member variable 'ParticleSystem::y' is not initialized in the constructor.
[../plugins/firepaint/src/firepaint.cpp:458]: (performance) Checking for 'points' emptiness might be inefficient. Using points.empty() instead of points.size() can be faster. points.size() can take linear time but points.empty() is guaranteed to take constant time.
[../plugins/firepaint/src/firepaint.cpp:482]: (performance) Checking for 'points' emptiness might be inefficient. Using points.empty() instead of points.size() can be faster. points.size() can take linear time but points.empty() is guaranteed to take constant time.
[../plugins/grid/src/grid.h:56]: (warning) Member variable 'GridProps::gravityRight' is not initialized in the constructor.
[../plugins/grid/src/grid.h:56]: (warning) Member variable 'GridProps::gravityDown' is not initialized in the constructor.
[../plugins/grid/src/grid.h:56]: (warning) Member variable 'GridProps::numCellsX' is not initialized in the constructor.
[../plugins/grid/src/grid.h:56]: (warning) Member variable 'GridProps::numCellsY' is not initialized in the constructor.
[../plugins/grid/src/grid.cpp:714]: (performance) Checking for 'animations' emptiness might be inefficient. Using animations.empty() instead of animations.size() can be faster. animations.size() can take linear time but animations.empty() is guaranteed to take constant time.
[../plugins/group/src/init.cpp:121]: (performance) Checking for 'mGroups' emptiness might be inefficient. Using mGroups.empty() instead of mGroups.size() can be faster. mGroups.size() can take linear time but mGroups.empty() is guaranteed to take constant time.
[../plugins/group/src/init.cpp:231]: (performance) Checking for 'mGroups' emptiness might be inefficient. Using mGroups.empty() instead of mGroups.size() can be faster. mGroups.size() can take linear time but mGroups.empty() is guaranteed to take constant time.
[../plugins/group/src/init.cpp:140]: (error) Uninitialized variable: group
[../plugins/group/src/init.cpp:141]: (error) Uninitialized variable: group
[../plugins/group/src/tab.cpp:2946]: (warning) Member variable 'GroupTabBar::mNextDirection' is not initialized in the constructor.
[../plugins/opacify/src/opacify.cpp:238]: (performance) Checking for 'passive' emptiness might be inefficient. Using passive.empty() instead of passive.size() can be faster. passive.size() can take linear time but passive.empty() is guaranteed to take constant time.
[../plugins/opengl/src/screen.cpp:659]: (style) The second of the two statements can never be executed, and so should be removed.
[../plugins/place/src/place.cpp:439]: (style) Suspicious expression. Boolean result is used in bitwise operation. The ! operator and the comparison operators have higher precedence than bitwise operators. It is recommended that the expression is clarified with parentheses.
[../plugins/ring/src/ring.cpp:454] -> [../plugins/ring/src/ring.cpp:452]: (style) Finding the same code for an if branch and an else branch is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct.
[../plugins/ring/src/ring.cpp:224]: (style) The scope of the variable 'pixmap' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../plugins/ring/src/ring.cpp:1141]: (performance) Checking for 'mWindows' emptiness might be inefficient. Using mWindows.empty() instead of mWindows.size() can be faster. mWindows.size() can take linear time but mWindows.empty() is guaranteed to take constant time.
[../plugins/scale/src/scale.cpp:520]: (performance) Checking for 'slotAreas' emptiness might be inefficient. Using slotAreas.empty() instead of slotAreas.size() can be faster. slotAreas.size() can take linear time but slotAreas.empty() is guaranteed to take constant time.
[../plugins/screenshot/src/screenshot.cpp:125]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../plugins/screenshot/src/screenshot.cpp:203]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../plugins/shift/src/shift.cpp:1455]: (style) The scope of the variable 'i' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../plugins/shift/src/shift.cpp:826]: (error) Common realloc mistake: 'mWindows' nulled but not freed upon failure
[../plugins/shift/src/shift.cpp:836]: (error) Common realloc mistake: 'mDrawSlots' nulled but not freed upon failure
[../plugins/showmouse/src/showmouse.cpp:57]: (warning) Member variable 'ParticleSystem::x' is not initialized in the constructor.
[../plugins/showmouse/src/showmouse.cpp:57]: (warning) Member variable 'ParticleSystem::y' is not initialized in the constructor.
[../plugins/showmouse/src/showmouse.cpp:62]: (warning) Member variable 'ParticleSystem::x' is not initialized in the constructor.
[../plugins/showmouse/src/showmouse.cpp:62]: (warning) Member variable 'ParticleSystem::y' is not initialized in the constructor.
[../plugins/stackswitch/src/stackswitch.cpp:619]: (error) Common realloc mistake: 'mWindows' nulled but not freed upon failure
[../plugins/stackswitch/src/stackswitch.cpp:624]: (error) Common realloc mistake: 'mDrawSlots' nulled but not freed upon failure
[../plugins/staticswitcher/src/staticswitcher.cpp:1249]: (warning) Member variable 'StaticSwitchScreen::previewWidth' is not initialized in the constructor.
[../plugins/staticswitcher/src/staticswitcher.cpp:1249]: (warning) Member variable 'StaticSwitchScreen::previewHeight' is not initialized in the constructor.
[../plugins/staticswitcher/src/staticswitcher.cpp:1249]: (warning) Member variable 'StaticSwitchScreen::previewBorder' is not initialized in the constructor.
[../plugins/staticswitcher/src/staticswitcher.cpp:1249]: (warning) Member variable 'StaticSwitchScreen::xCount' is not initialized in the constructor.
[../plugins/thumbnail/src/thumbnail.cpp:806]: (performance) Checking for 'damageThumbs' emptiness might be inefficient. Using damageThumbs.empty() instead of damageThumbs.size() can be faster. damageThumbs.size() can take linear time but damageThumbs.empty() is guaranteed to take constant time.
[../plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::radius' is not initialized in the constructor.
[../plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::rMod' is not initialized in the constructor.
[../plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::duration' is not initialized in the constructor.
[../plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::timer' is not initialized in the constructor.
[../plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::width' is not initialized in the constructor.
[../plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::height' is not initialized in the constructor.
[../plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::adjust' is not initialized in the constructor.
[../plugins/wallpaper/src/wallpaper.cpp:373]: (performance) Checking for 'backgroundsPrimary' emptiness might be inefficient. Using backgroundsPrimary.empty() instead of backgroundsPrimary.size() can be faster. backgroundsPrimary.size() can take linear time but backgroundsPrimary.empty() is guaranteed to take constant time.
[../plugins/wallpaper/src/wallpaper.cpp:574]: (performance) Checking for 'backgroundsPrimary' emptiness might be inefficient. Using backgroundsPrimary.empty() instead of backgroundsPrimary.size() can be faster. backgroundsPrimary.size() can take linear time but backgroundsPrimary.empty() is guaranteed to take constant time.
[../plugins/wobbly/src/wobbly.cpp:37]: (style) The scope of the variable 'v' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../plugins/wobbly/src/wobbly.cpp:38]: (style) The scope of the variable 's' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../plugins/wobbly/src/wobbly.cpp:39]: (style) The scope of the variable 'e' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../plugins/wobbly/src/wobbly.cpp:145]: (style) The scope of the variable 'v' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../plugins/wobbly/src/wobbly.cpp:146]: (style) The scope of the variable 's' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../plugins/wobbly/src/wobbly.cpp:147]: (style) The scope of the variable 'e' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../plugins/wobbly/src/wobbly.cpp:252]: (style) The scope of the variable 'v' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../plugins/wobbly/src/wobbly.cpp:253]: (style) The scope of the variable 's' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../plugins/wobbly/src/wobbly.cpp:254]: (style) The scope of the variable 'e' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../plugins/wobbly/src/wobbly.cpp:359]: (style) The scope of the variable 'v' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../plugins/wobbly/src/wobbly.cpp:360]: (style) The scope of the variable 's' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../plugins/wobbly/src/wobbly.cpp:361]: (style) The scope of the variable 'e' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../plugins/wobbly/src/wobbly.cpp:2144]: (style) The scope of the variable 'i' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../plugins/wobbly/src/wobbly.cpp:887]: (warning) Member variable 'Model::springs' is not initialized in the constructor.
[../src/action.cpp:292]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../src/match.cpp:394]: (performance) Checking for 'list' emptiness might be inefficient. Using list.empty() instead of list.size() can be faster. list.size() can take linear time but list.empty() is guaranteed to take constant time.
[../src/screen.cpp:2276]: (style) C-style pointer casting
[../src/screen.cpp:1154]: (style) The scope of the variable 'icccmVersion' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../src/screen.cpp:1091]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container.
[../src/screen.cpp:2133]: (performance) Checking for 'screenInfo' emptiness might be inefficient. Using screenInfo.empty() instead of screenInfo.size() can be faster. screenInfo.size() can take linear time but screenInfo.empty() is guaranteed to take constant time.
[../src/stackdebugger.cpp:51]: (warning) Member variable 'StackDebugger::mTimeoutRequired' is not initialized in the constructor.
[../src/string/tests/printf/src/test-string-printf.cpp:52]: (warning) Member variable 'Value::v' is not initialized in the constructor.
[../src/window.cpp:2005]: (error) Analysis failed. If the code is valid then please report this failure.

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2012-07-30:

#

7 for (map <string, vector<string> >::iterator it = testCases.begin ();
8 - it != testCases.end (); it++)
9 + it != testCases.end (); ++it)
10 {
11 for (vector <string>::iterator jt = it->second.begin ();
12 - jt != it->second.end (); jt++)
13 + jt != it->second.end (); ++jt)
14 {
15 if (testfilecmake.good ())
16 {

That's fine - you just need to fix the indentation on lines 9 and 13 of the diff (make it line up with the parens)

51 + int j;
52 for (j = 0; j < num; j++)
53 {

Indentation (should be 1 tab)

68 + int j, num = option.int_desc_size ();
69 for (j = 0; j < num; j++)
70 {

ditto ... there seem to be a lot of places where the indentation isn't quite right. Compiz uses the X11 scheme (which is stupid, but we shouldn't change it)

1 indent: 4 spaces
2 indents: 1 tab (8 wide)
3 indents: 1 tab 4 spaces
4 indents: 2 tabs

etc

You might want to change these:

505 - lastX = -1000000000.0;
506 + float lastX = -1000000000.0, lastZ = 0.0;
507
508 for (i = oldVCount; i < geometry.vCount; i++)
509 {
510 @@ -728,7 +727,7 @@
511 last[0][0] = -1000000000.0;
512 last[1][0] = -1000000000.0;

to

float lastX = std::numeric_limits <float>::min (), rather than their current magic number of -1000000000.0

595 - left = 0;
596 - right = minWidth;
597 - top = 0;
598 - bottom = minHeight;
599 + int left = 0, right = minWidth, top = 0, bottom = minHeight;

Keep these on separate lines, its a bit easier to read

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2012-07-30:

#

Lots of indentation needs fixing. Look at the Preview Diff.

I'm not concerned about multiple declarations on one line. It makes sense when the variables are related and/or the line is not very long.

review: Needs Fixing

Revision history for this message

MC Return (mc-return) wrote on 2012-07-30:

#

Daniel, I am sorry about the indentation problems.

I tried to not create any new ones ;), but the diff here shows the code differently than the code editor (QTCreator) that I am currently using - it seems that QTCreator is inserting spaces automatically, when I use Tabulator and I am a bit confused about the strange looking diff here...

Also when reading the code it seemed that inconsistent indentation was already an existing problem...

How about using some specialized tool to fix all of those indentation and stylistic problems automatically ?
I've heard recommendations for the code beautifier "Artistic Style" for example: http://astyle.sourceforge.net/

Also: Are the fixes already done in this branch ok so far, except from the wrong indentation, and do you have any comments on the remaining problems cppcheck found and how to best fix those ?

review: Needs Information

lp://qastaging/~mc-return/compiz/compiz.fix1030473-part1 updated on 2012-07-30

3423. By MC Return on 2012-07-30: Hopefully fixed indentation

Revision history for this message

MC Return (mc-return) wrote on 2012-07-30:

#

The strange thing is that I did not touch the indentation at all, when I changed postfix to prefix operators for example, and it looks correct when I check it in QTCreator, but the diff here says otherwise... :(

lp://qastaging/~mc-return/compiz/compiz.fix1030473-part1 updated on 2012-07-30

3424. By MC Return on 2012-07-30: Hopefully fixed indentation
3425. By MC Return on 2012-07-30: Hopefully fixed indentation
3426. By MC Return on 2012-07-30: Hopefully fixed indentation
3427. By MC Return on 2012-07-30: Hopefully fixed indentation
3428. By MC Return on 2012-07-30: Hopefully fixed identation
3429. By MC Return on 2012-07-30: Hopefully fixed indentation
3430. By MC Return on 2012-07-30: Hopefully fixed indentation
3431. By MC Return on 2012-07-30: Hopefully fixed indentation (although grid.cpp does not follow the 4 spaces/tabulator style and uses other method of indentation)
3432. By MC Return on 2012-07-30: Hopefully fixed indentation
3433. By MC Return on 2012-07-30: Hopefully fixed indentation
3434. By MC Return on 2012-07-30: Hopefully fixed indentation
3435. By MC Return on 2012-07-30: Hopefully fixed indentation
3436. By MC Return on 2012-07-30: Hopefully fixed indentation

Revision history for this message

MC Return (mc-return) wrote on 2012-07-30:

#

Sometimes (in the for loops) Tabulator + 5 Spaces were used, I am not sure about those (I used TAB + 4 Spaces)...

The rest of the problems should now be fixed. I hope we can merge this branch ASAP, before starting work on the remaining problems cppcheck detected as those are the more complicated ones and should IMHO not be mixed into one large diff to provide better readability. That is why I named this branch compiz.fix1030473-part1 in the first place ;).

review: Needs Resubmitting

lp://qastaging/~mc-return/compiz/compiz.fix1030473-part1 updated on 2012-07-30

3437. By MC Return on 2012-07-30: Fixed possible performance problem by replacing postfix operator with prefix one for the variable 'it'
3438. By MC Return on 2012-07-30: Fixed possible performance problem by replacing postfix operator with prefix one for the variables 'it' and 'cur'
3439. By MC Return on 2012-07-30: Fixed possible performance problem by replacing postfix operator with prefix one for the variable 'it'
3440. By MC Return on 2012-07-30: Hopefully fixed indentation
3441. By MC Return on 2012-07-30: Reduced the scope of the variable 'temp'
3442. By MC Return on 2012-07-30: Reduced the scope of the variable 'pixmap'
3443. By MC Return on 2012-07-30: Reduced the scope of the variable 'i'
3444. By MC Return on 2012-07-30: Reduced the scope of the variables 'v', 's' and 'e'
3445. By MC Return on 2012-07-30: Reduced the scope of the variables 'v', 's' and 'e'
3446. By MC Return on 2012-07-30: Reduced the scope of the variables 'v', 's' and 'e'
3447. By MC Return on 2012-07-30: Reduced the scope of the variables 'v', 's' and 'e'
3448. By MC Return on 2012-07-30: Reduced the scope of the variable 'i'

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2012-07-30:

#

Looks good now, the only indentation thing that remains is aligning the next line of the for statements with the content of the statement itself and not the brace, eg

for (....
....)

not

for (....
....)

As for Qt Creator, here are the settings I use:

http://fpaste.org/MOvt/

lp://qastaging/~mc-return/compiz/compiz.fix1030473-part1 updated on 2012-07-30

3449. By MC Return on 2012-07-30: Reduced the scope of the variable 'icccmVersion'

Revision history for this message

MC Return (mc-return) wrote on 2012-07-30:

#

Sam, thanks for the comment. I will fix those also, now that I understand how it is supposed to be :)

And thanks a lot for your Qt Creator settings !

Revision history for this message

MC Return (mc-return) wrote on 2012-07-30:

#

Download full text (34.9 KiB)

Remaining problems detected:

[../compizconfig/gconf/src/gconf.c:479]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
%s => %20s
%i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compizconfig/gconf/src/gconf.c:1930]: (error) Memory pointed to by 'pathName' is freed twice.
[../compizconfig/gsettings/gsettings_backend_shared/gsettings_util.c:184]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
%s => %20s
%i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compizconfig/gsettings/src/gsettings.c:296]: (warning) Casting between double* and float* which have an incompatible binary data representation
[../compizconfig/libcompizconfig/backend/src/ini.c:686]: (error) Memory pointed to by 'filePath' is freed twice.
[../compizconfig/libcompizconfig/backend/src/ini.c:187]: (error) Common realloc mistake: 'privData' nulled but not freed upon failure
[../compizconfig/libcompizconfig/backend/src/ini.c:221]: (error) Common realloc mistake: 'privData' nulled but not freed upon failure
[../compizconfig/libcompizconfig/src/bindings.c:380]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
%s => %20s
%i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compizconfig/libcompizconfig/src/compiz.cpp:3039]: (warning) sscanf %s in format string (no. 1) does not specify a width, use %1023s to prevent overflowing destination: name[1024]
[../compizconfig/libcompizconfig/src/compiz.cpp:3039]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
%s => %20s
%i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compizconfig/libcompizconfig/src/compiz.cpp:2705]: (error) Memory leak: pbFile
[../compizconfig/libcompizconfig/src/compiz.cpp:2771]: (error) Memory leak: pbFile
[../compizconfig/libcompizconfig/src/filewatch.c:113]: (error) Common realloc mistake: 'fwData' nulled but not freed upon failure
[../compizconfig/libcompizconfig/src/filewatch.c:173]: (error) Common realloc mistake: 'fwData' nulled but not freed upon failure
[../compizconfig/libcompizconfig/src/ini.c:791]: (error) Common realloc mistake: 'stringBuffer' nulled but not freed upon failure
[../compizconfig/libcompizconfig/src/iniparser.c:123]: (style) Defensive programming: The variable i is used as array index and then there is a check that it is within limits. This can mean that the array might be accessed out-of-bounds. Reorder conditions such ...

Remaining problems detected:

[../compizconfig/gconf/src/gconf.c:479]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compizconfig/gconf/src/gconf.c:1930]: (error) Memory pointed to by 'pathName' is freed twice.
[../compizconfig/gsettings/gsettings_backend_shared/gsettings_util.c:184]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compizconfig/gsettings/src/gsettings.c:296]: (warning) Casting between double* and float* which have an incompatible binary data representation
[../compizconfig/libcompizconfig/backend/src/ini.c:686]: (error) Memory pointed to by 'filePath' is freed twice.
[../compizconfig/libcompizconfig/backend/src/ini.c:187]: (error) Common realloc mistake: 'privData' nulled but not freed upon failure
[../compizconfig/libcompizconfig/backend/src/ini.c:221]: (error) Common realloc mistake: 'privData' nulled but not freed upon failure
[../compizconfig/libcompizconfig/src/bindings.c:380]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compizconfig/libcompizconfig/src/compiz.cpp:3039]: (warning) sscanf %s in format string (no. 1) does not specify a width, use %1023s to prevent overflowing destination: name[1024]
[../compizconfig/libcompizconfig/src/compiz.cpp:3039]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../compizconfig/libcompizconfig/src/compiz.cpp:2705]: (error) Memory leak: pbFile
[../compizconfig/libcompizconfig/src/compiz.cpp:2771]: (error) Memory leak: pbFile
[../compizconfig/libcompizconfig/src/filewatch.c:113]: (error) Common realloc mistake: 'fwData' nulled but not freed upon failure
[../compizconfig/libcompizconfig/src/filewatch.c:173]: (error) Common realloc mistake: 'fwData' nulled but not freed upon failure
[../compizconfig/libcompizconfig/src/ini.c:791]: (error) Common realloc mistake: 'stringBuffer' nulled but not freed upon failure
[../compizconfig/libcompizconfig/src/iniparser.c:123]: (style) Defensive programming: The variable i is used as array index and then there is a check that it is within limits. This can mean that the array might be accessed out-of-bounds. Reorder conditions such as '(a[i] && i < 10)' to '(i < 10 && a[i])'. That way the array will not be accessed when the index is out of limits.
[../compizconfig/libcompizconfig/src/main.c:656]: (error) Possible null pointer dereference: subGroup - otherwise it is redundant to check if subGroup is null at line 657
[../compizconfig/libcompizconfig/src/main.c:3213]: (error) Possible null pointer dereference: conflict - otherwise it is redundant to check if conflict is null at line 3214
[../compizconfig/libcompizconfig/src/main.c:4305]: (error) Read and write operations without a call to a positioning function (fseek, fsetpos or rewind) or fflush inbetween result in undefined behaviour.
[../compizconfig/libcompizconfig/src/main.c:259]: (error) Memory pointed to by 'val' is freed twice.
[../compizconfig/libcompizconfig/src/main.c:267]: (error) Memory pointed to by 'val' is freed twice.
[../compizconfig/libcompizconfig/src/main.c:275]: (error) Memory pointed to by 'val' is freed twice.
[../compizconfig/libcompizconfig/src/main.c:1037]: (error) Memory pointed to by 'dlname' is freed twice.
[../compizconfig/libcompizconfig/src/main.c:3485]: (error) Memory pointed to by 'backenddir' is freed twice.
[../compizconfig/libcompizconfig/src/main.c:3495]: (error) Memory pointed to by 'backenddir' is freed twice.
[../compizconfig/libcompizconfig/src/main.c:3626]: (error) Memory leak: sectionName
[../compizconfig/libcompizconfig/src/main.c:3784]: (error) Memory leak: sectionName
[../compizconfig/libcompizconfig/src/main.c:4262]: (error) Memory leak: completedUpgrades
[../compizconfig/libcompizconfig/src/main.c:4266]: (error) Memory leak: completedUpgrades
[../compizconfig/libcompizconfig/src/main.c:4262]: (error) Resource leak: completedUpgrades
[../compizconfig/libcompizconfig/tests/mock-context.h:94]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:100]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:106]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:112]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:118]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:124]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:130]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:136]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:142]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:148]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:154]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:160]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:166]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:172]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:178]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:187]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:196]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:205]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:211]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:217]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:223]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:232]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:241]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:250]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:259]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:265]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:271]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:280]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:289]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:295]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:304]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:313]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:322]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-context.h:331]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/context-mock.cpp:68]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:64]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:69]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:74]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:79]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:84]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:89]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:94]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:99]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:104]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:109]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:114]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:119]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:124]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:129]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:134]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:139]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:148]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:154]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-plugin.h:159]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/plugin-mock.cpp:55]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:119]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:125]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:131]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:137]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:143]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:149]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:155]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:161]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:167]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:173]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:179]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:186]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:193]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:200]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:207]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:214]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:221]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:228]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:235]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:242]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:249]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:256]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:263]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:268]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:273]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:278]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:283]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:289]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:294]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:299]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:304]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:309]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:314]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:319]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:324]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:329]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:334]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:339]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:344]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/mock-setting.h:349]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/setting-mock.cpp:77]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-ccs-object.cpp:86]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-ccs-object.cpp:100]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-ccs-object.cpp:120]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-ccs-object.cpp:129]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-ccs-object.cpp:146]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-ccs-object.cpp:180]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-ccs-object.cpp:192]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-ccs-object.cpp:299]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-ccs-object.cpp:327]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-context.cpp:19]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-plugin.cpp:19]: (style) C-style pointer casting
[../compizconfig/libcompizconfig/tests/test-setting.cpp:19]: (style) C-style pointer casting
[../gtk/window-decorator/cairo.c:732] -> [../gtk/window-decorator/cairo.c:732]: (style) Finding the same expression on both sides of an operator is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct.
[../gtk/window-decorator/decorator.c:1016]: (error) Memory leak: opts
[../gtk/window-decorator/frames.c:266]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/frames.c:269]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/frames.c:272]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/frames.c:275]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/frames.c:278]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/frames.c:281]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/frames.c:284]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/frames.c:287]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/frames.c:290]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/frames.c:293]: (error) Possible null pointer dereference: frame - otherwise it is redundant to check if frame is null at line 296
[../gtk/window-decorator/metacity.c:599]: (style) Variable 'frame_style' is assigned a value that is never used
[../kde/window-decorator-kde4/switcher.cpp:227]: (style) Variable 'frameType' is assigned a value that is never used
[../kde/window-decorator-kde4/switcher.cpp:227]: (style) Variable 'frameState' is assigned a value that is never used
[../kde/window-decorator-kde4/switcher.cpp:227]: (style) Variable 'frameActions' is assigned a value that is never used
[../libdecoration/decoration.c:3140]: (style) The scope of the variable 'icccm_version' can be reduced. Warning: It can be unsafe to fix this message. Be careful. Especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
    int i = 0;
    if (x) {
        // it's safe to move 'int i = 0' here
        for (int n = 0; n < 10; ++n) {
            // it is possible but not safe to move 'int i = 0' here
            do_something(&i);
        }
    }
}
When you see this message it is always safe to reduce the variable scope 1 level.
[../plugins/animation/src/extensionplugin.cpp:436]: (style) Defensive programming: The variable changeEnd is used as array index and then there is a check that it is within limits. This can mean that the array might be accessed out-of-bounds. Reorder conditions such as '(a[i] && i < 10)' to '(i < 10 && a[i])'. That way the array will not be accessed when the index is out of limits.
[../plugins/animation/src/glide.cpp:41]: (warning) Member variable 'GlideAnim::glideModRotAngle' is not initialized in the constructor.
[../plugins/animation/src/magiclamp.cpp:55]: (warning) Member variable 'MagicLampAnim::mTopLeftCornerObject' is not initialized in the constructor.
[../plugins/animation/src/magiclamp.cpp:55]: (warning) Member variable 'MagicLampAnim::mBottomLeftCornerObject' is not initialized in the constructor.
[../plugins/animation/src/options.cpp:127]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../plugins/animation/src/options.cpp:169]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../plugins/animation/src/options.cpp:224]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../plugins/animation/src/options.cpp:231]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../plugins/animation/src/options.cpp:247]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../plugins/animationaddon/src/airplane.cpp:127]: (style) C-style pointer casting
[../plugins/animationaddon/src/airplane.cpp:348]: (style) C-style pointer casting
[../plugins/animationaddon/src/airplane.cpp:533]: (style) C-style pointer casting
[../plugins/animationaddon/src/airplane.cpp:697]: (style) C-style pointer casting
[../plugins/animationaddon/src/airplane.cpp:747]: (style) C-style pointer casting
[../plugins/animationaddon/src/private.h:41]: (warning) Member variable 'ExtensionPluginAnimAddon::mOutput' is not initialized in the constructor.
[../plugins/animationaddon/src/polygon.cpp:459]: (style) Suspicious calculation. Please use parentheses to clarify the code. The code 'a%b?c:d' should be written as either '(a%b)?c:d' or 'a%(b?c:d)'.
[../plugins/colorfilter/src/colorfilter.cpp:252]: (error) Possible null pointer dereference: func - otherwise it is redundant to check if func is null at line 255
[../plugins/colorfilter/src/parser.h:34]: (style) The class 'FragmentParser 'does not have a constructor but it has attributes. The attributes are not initialized which may cause bugs or undefined behavior.
[../plugins/colorfilter/src/colorfilter.cpp:301]: (performance) Checking for 'filtersFunctions' emptiness might be inefficient. Using filtersFunctions.empty() instead of filtersFunctions.size() can be faster. filtersFunctions.size() can take linear time but filtersFunctions.empty() is guaranteed to take constant time.
[../plugins/colorfilter/src/parser.cpp:177]: (style) Suspicious condition (assignment+comparison), it can be clarified with parentheses
[../plugins/colorfilter/src/parser.cpp:178]: (style) Suspicious condition (assignment+comparison), it can be clarified with parentheses
[../plugins/colorfilter/src/parser.cpp:439]: (performance) Checking for 'offsets' emptiness might be inefficient. Using offsets.empty() instead of offsets.size() can be faster. offsets.size() can take linear time but offsets.empty() is guaranteed to take constant time.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::compositeEvent' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::compositeError' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::compositeOpcode' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::damageEvent' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::damageError' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::fixesEvent' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::fixesError' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::fixesVersion' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::shapeExtension' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::shapeEvent' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::shapeError' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::randrExtension' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::randrEvent' is not initialized in the constructor.
[../plugins/composite/src/screen.cpp:276]: (warning) Member variable 'PrivateCompositeScreen::randrError' is not initialized in the constructor.
[../plugins/dbus/src/dbus.cpp:1528]: (performance) Checking for 'path' emptiness might be inefficient. Using path.empty() instead of path.size() can be faster. path.size() can take linear time but path.empty() is guaranteed to take constant time.
[../plugins/decor/src/decor.cpp:581]: (warning) Member variable 'Decoration::refCount' is not initialized in the constructor.
[../plugins/decor/src/decor.cpp:1326]: (performance) Checking for 'mList' emptiness might be inefficient. Using mList.empty() instead of mList.size() can be faster. mList.size() can take linear time but mList.empty() is guaranteed to take constant time.
[../plugins/ezoom/src/ezoom.cpp:1794]: (warning) Member variable 'CursorTexture::screen' is not initialized in the constructor.
[../plugins/ezoom/src/ezoom.cpp:1794]: (warning) Member variable 'CursorTexture::width' is not initialized in the constructor.
[../plugins/ezoom/src/ezoom.cpp:1794]: (warning) Member variable 'CursorTexture::height' is not initialized in the constructor.
[../plugins/ezoom/src/ezoom.cpp:1794]: (warning) Member variable 'CursorTexture::hotX' is not initialized in the constructor.
[../plugins/ezoom/src/ezoom.cpp:1794]: (warning) Member variable 'CursorTexture::hotY' is not initialized in the constructor.
[../plugins/ezoom/src/ezoom.cpp:213]: (warning) Member variable 'ZoomArea::output' is not initialized in the constructor.
[../plugins/firepaint/src/firepaint.cpp:52]: (warning) Member variable 'ParticleSystem::x' is not initialized in the constructor.
[../plugins/firepaint/src/firepaint.cpp:52]: (warning) Member variable 'ParticleSystem::y' is not initialized in the constructor.
[../plugins/firepaint/src/firepaint.cpp:57]: (warning) Member variable 'ParticleSystem::x' is not initialized in the constructor.
[../plugins/firepaint/src/firepaint.cpp:57]: (warning) Member variable 'ParticleSystem::y' is not initialized in the constructor.
[../plugins/firepaint/src/firepaint.cpp:458]: (performance) Checking for 'points' emptiness might be inefficient. Using points.empty() instead of points.size() can be faster. points.size() can take linear time but points.empty() is guaranteed to take constant time.
[../plugins/firepaint/src/firepaint.cpp:482]: (performance) Checking for 'points' emptiness might be inefficient. Using points.empty() instead of points.size() can be faster. points.size() can take linear time but points.empty() is guaranteed to take constant time.
[../plugins/grid/src/grid.h:56]: (warning) Member variable 'GridProps::gravityRight' is not initialized in the constructor.
[../plugins/grid/src/grid.h:56]: (warning) Member variable 'GridProps::gravityDown' is not initialized in the constructor.
[../plugins/grid/src/grid.h:56]: (warning) Member variable 'GridProps::numCellsX' is not initialized in the constructor.
[../plugins/grid/src/grid.h:56]: (warning) Member variable 'GridProps::numCellsY' is not initialized in the constructor.
[../plugins/grid/src/grid.cpp:714]: (performance) Checking for 'animations' emptiness might be inefficient. Using animations.empty() instead of animations.size() can be faster. animations.size() can take linear time but animations.empty() is guaranteed to take constant time.
[../plugins/group/src/init.cpp:121]: (performance) Checking for 'mGroups' emptiness might be inefficient. Using mGroups.empty() instead of mGroups.size() can be faster. mGroups.size() can take linear time but mGroups.empty() is guaranteed to take constant time.
[../plugins/group/src/init.cpp:231]: (performance) Checking for 'mGroups' emptiness might be inefficient. Using mGroups.empty() instead of mGroups.size() can be faster. mGroups.size() can take linear time but mGroups.empty() is guaranteed to take constant time.
[../plugins/group/src/init.cpp:140]: (error) Uninitialized variable: group
[../plugins/group/src/init.cpp:141]: (error) Uninitialized variable: group
[../plugins/group/src/tab.cpp:2946]: (warning) Member variable 'GroupTabBar::mNextDirection' is not initialized in the constructor.
[../plugins/opacify/src/opacify.cpp:238]: (performance) Checking for 'passive' emptiness might be inefficient. Using passive.empty() instead of passive.size() can be faster. passive.size() can take linear time but passive.empty() is guaranteed to take constant time.
[../plugins/opengl/src/screen.cpp:659]: (style) The second of the two statements can never be executed, and so should be removed.
[../plugins/place/src/place.cpp:439]: (style) Suspicious expression. Boolean result is used in bitwise operation. The ! operator and the comparison operators have higher precedence than bitwise operators. It is recommended that the expression is clarified with parentheses.
[../plugins/ring/src/ring.cpp:454] -> [../plugins/ring/src/ring.cpp:452]: (style) Finding the same code for an if branch and an else branch is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct.
[../plugins/ring/src/ring.cpp:1141]: (performance) Checking for 'mWindows' emptiness might be inefficient. Using mWindows.empty() instead of mWindows.size() can be faster. mWindows.size() can take linear time but mWindows.empty() is guaranteed to take constant time.
[../plugins/scale/src/scale.cpp:520]: (performance) Checking for 'slotAreas' emptiness might be inefficient. Using slotAreas.empty() instead of slotAreas.size() can be faster. slotAreas.size() can take linear time but slotAreas.empty() is guaranteed to take constant time.
[../plugins/screenshot/src/screenshot.cpp:125]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../plugins/screenshot/src/screenshot.cpp:203]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../plugins/shift/src/shift.cpp:826]: (error) Common realloc mistake: 'mWindows' nulled but not freed upon failure
[../plugins/shift/src/shift.cpp:836]: (error) Common realloc mistake: 'mDrawSlots' nulled but not freed upon failure
[../plugins/showmouse/src/showmouse.cpp:57]: (warning) Member variable 'ParticleSystem::x' is not initialized in the constructor.
[../plugins/showmouse/src/showmouse.cpp:57]: (warning) Member variable 'ParticleSystem::y' is not initialized in the constructor.
[../plugins/showmouse/src/showmouse.cpp:62]: (warning) Member variable 'ParticleSystem::x' is not initialized in the constructor.
[../plugins/showmouse/src/showmouse.cpp:62]: (warning) Member variable 'ParticleSystem::y' is not initialized in the constructor.
[../plugins/stackswitch/src/stackswitch.cpp:619]: (error) Common realloc mistake: 'mWindows' nulled but not freed upon failure
[../plugins/stackswitch/src/stackswitch.cpp:624]: (error) Common realloc mistake: 'mDrawSlots' nulled but not freed upon failure
[../plugins/staticswitcher/src/staticswitcher.cpp:1249]: (warning) Member variable 'StaticSwitchScreen::previewWidth' is not initialized in the constructor.
[../plugins/staticswitcher/src/staticswitcher.cpp:1249]: (warning) Member variable 'StaticSwitchScreen::previewHeight' is not initialized in the constructor.
[../plugins/staticswitcher/src/staticswitcher.cpp:1249]: (warning) Member variable 'StaticSwitchScreen::previewBorder' is not initialized in the constructor.
[../plugins/staticswitcher/src/staticswitcher.cpp:1249]: (warning) Member variable 'StaticSwitchScreen::xCount' is not initialized in the constructor.
[../plugins/thumbnail/src/thumbnail.cpp:806]: (performance) Checking for 'damageThumbs' emptiness might be inefficient. Using damageThumbs.empty() instead of damageThumbs.size() can be faster. damageThumbs.size() can take linear time but damageThumbs.empty() is guaranteed to take constant time.
[../plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::radius' is not initialized in the constructor.
[../plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::rMod' is not initialized in the constructor.
[../plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::duration' is not initialized in the constructor.
[../plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::timer' is not initialized in the constructor.
[../plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::width' is not initialized in the constructor.
[../plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::height' is not initialized in the constructor.
[../plugins/trip/src/trip.cpp:560]: (warning) Member variable 'Ripple::adjust' is not initialized in the constructor.
[../plugins/wallpaper/src/wallpaper.cpp:373]: (performance) Checking for 'backgroundsPrimary' emptiness might be inefficient. Using backgroundsPrimary.empty() instead of backgroundsPrimary.size() can be faster. backgroundsPrimary.size() can take linear time but backgroundsPrimary.empty() is guaranteed to take constant time.
[../plugins/wallpaper/src/wallpaper.cpp:574]: (performance) Checking for 'backgroundsPrimary' emptiness might be inefficient. Using backgroundsPrimary.empty() instead of backgroundsPrimary.size() can be faster. backgroundsPrimary.size() can take linear time but backgroundsPrimary.empty() is guaranteed to take constant time.
[../plugins/wobbly/src/wobbly.cpp:891]: (warning) Member variable 'Model::springs' is not initialized in the constructor.
[../src/action.cpp:292]: (warning) scanf without field width limits can crash with huge input data. To fix this error message add a field width specifier:
    %s => %20s
    %i => %3i

Sample program that can crash:

#include <stdio.h>
int main()
{
    int a;
    scanf("%i", &a);
    return 0;
}

To make it crash:
perl -e 'print "5"x2100000' | ./a.out
[../src/match.cpp:394]: (performance) Checking for 'list' emptiness might be inefficient. Using list.empty() instead of list.size() can be faster. list.size() can take linear time but list.empty() is guaranteed to take constant time.
[../src/screen.cpp:2278]: (style) C-style pointer casting
[../src/screen.cpp:1091]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container.
[../src/screen.cpp:2135]: (performance) Checking for 'screenInfo' emptiness might be inefficient. Using screenInfo.empty() instead of screenInfo.size() can be faster. screenInfo.size() can take linear time but screenInfo.empty() is guaranteed to take constant time.
[../src/stackdebugger.cpp:51]: (warning) Member variable 'StackDebugger::mTimeoutRequired' is not initialized in the constructor.
[../src/string/tests/printf/src/test-string-printf.cpp:52]: (warning) Member variable 'Value::v' is not initialized in the constructor.
[../src/window.cpp:2005]: (error) Analysis failed. If the code is valid then please report this failure.

lp://qastaging/~mc-return/compiz/compiz.fix1030473-part1 updated on 2012-07-30

3450. By MC Return on 2012-07-30: Fixed indentation
3451. By MC Return on 2012-07-30: Fixed indentation
3452. By MC Return on 2012-07-30: Fixed intendation
3453. By MC Return on 2012-07-30: Fixed intendation
3454. By MC Return on 2012-07-30: Fixed intendation
3455. By MC Return on 2012-07-30: Fixed intendation
3456. By MC Return on 2012-07-30: Fixed intendation
3457. By MC Return on 2012-07-30: Fixed intendation
3458. By MC Return on 2012-07-30: Fixed intendation
3459. By MC Return on 2012-07-30: Fixed intendation

Revision history for this message

MC Return (mc-return) wrote on 2012-07-30:

#

Okay, should be ready now... :)

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2012-07-30:

#

LGTM

review: Approve

lp://qastaging/~mc-return/compiz/compiz.fix1030473-part1 updated on 2012-07-30

3460. By MC Return on 2012-07-30: Replaced the magic number assignment of the variable 'lastX' by 'float lastX = std::numeric_limits <float>::min ()'

Revision history for this message

MC Return (mc-return) wrote on 2012-07-30:

#

I hope r3460 is okay as well ;) (followed your suggestion in your first comment here).

Revision history for this message

MC Return (mc-return) on 2012-07-31:

#

review: Needs Resubmitting

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2012-08-03:

#

Looks OK and passes basic testing too.

review: Approve

Compiz

Merge lp://qastaging/~mc-return/compiz/compiz.fix1030473-part1 into lp://qastaging/compiz/0.9.8

Commit message

Description of the change

Preview Diff

Subscribers