Merge lp://qastaging/~mc-return/compiz/compiz.merge-fix1082001-gridded-windows-jump-workspaces into lp://qastaging/compiz/0.9.10
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sami Jaktholm | Pending | ||
Compiz Maintainers | Pending | ||
Review via email:
|
This proposal supersedes a proposal from 2013-04-05.
This proposal has been superseded by a proposal from 2013-04-08.
Commit message
*Grid code:
Prevent center and corner gridded windows from jumping viewports.
(Thanks and credits for this go to Sami Jaktholm)
Prevent top and bottom gridded windows from jumping viewports by
making those semi-maximize horizontally.
As those are actually semi-maximized horizontally, we will treat
them as such and let core handle the restoring, just like we
already do for vertically semi-maximized grid windows (left/right).
Now "Strg+Super+Down" will restore top and bottom gridded windows
correctly as well.
Also multiple gridding to top, bottom, left or right will not
overwrite the stored original size anymore.
Restore windows also when workspace switcher (expo) is active.
(Thanks and credits for this go to Sami Jaktholm)
Allow cycling for all gridded windows if explicitly specified by the
user in CCSM.
Forbid cycling through different sizes for corner and center-gridded
windows also per default, now fully fixing bug #878820 and following
the design specification by Ayatana Design there, making behaviour
consistent.
*Grid xml:
Added cycle_sizes bool option, which allows the user to choose the
prefered behaviour (fixed versus flexible sizes on multiple presses
on the same grid keyboard shortcut).
Default of this option is off, cycling disabled as specified by design.
Added punctuation where missing and removed it where usually is none.
Fixed typos, improved description and titles.
*Expo code:
Tell grid when viewport change is in progress.
(Thanks and credits for this go to Sami Jaktholm)
(fixes: LP: #878820, LP: #879218, LP: #882754 and LP: #1082001,
partially fixes: #1116538, #1164332)
Unmerged revisions
- 3661. By MC Return
-
Merged latest lp:compiz
- 3660. By MC Return
-
Merged Grid from latest lp:compiz
Simplified bool GridScreen:
:restoreWindow (...):
If Grid has not touched the window we return false and let core do the
dirty work (Thanks go to Sam Spilsbury for suggesting this)Improved the CCSM grid restore tooltip
- 3659. By MC Return
-
Grid xml:
Improved tooltip for the "put_restore_key" reflecting it's enhanced
functionality. - 3658. By MC Return
-
Grid:
We want to use the same functionality like the unmaximize_or_minimize_ window
shortcut normally provides, so if our window has not been touched by grid, we
will do the same with that window that core would normally do
(see src/actions.cpp, unmaximizeOrMinimizeWin and
launchpad bug LP: #1116538 for details)Note: If we use the same shortcut for unmaximize_
or_minimize_ window_ key (core)
and put_restore_key (grid) core will take over again, if grid gets disabled
If grid is enabled the unmaximize_or_minimize_ window_ key will be overridden,
because core always loads first and grid laterAlso note that this commit did not change any shortcut yet, but just provides
the functionality for grid - Please use your grid restore keybinding like you
would use the unmaximize_or_minimize_ window_ key normally to test
Ping ?