lp://qastaging/~mc-return/compiz/compiz0.9.8.merge-fix1067534

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://qastaging/compiz/0.9.8 at revision 3409

Marco Trevisan (Treviño): Approve on 2012-10-17

Diff: 23 lines (+2/-0)

2 files modified

plugins/fadedesktop/fadedesktop.xml.in (+1/-0)
plugins/showdesktop/showdesktop.xml.in (+1/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1067534: "Show desktop" plug-in actually works with Unity when ensured that it is loaded after unityshell

Low

Fix Released

Link a bug report

Related blueprints

3410. By MC Return on 2012-10-17

fadedesktop plug-in should conflict with unityshell and showdesktop

3409. By MC Return on 2012-10-17

Ensure showdesktop is started after unityshell.

3408. By Daniel van Vugt on 2012-10-16

Avoid duplicate template instantiations of PluginClassHandler<>, at least
for those plugins that get re-used by others.

Duplicate template instances are normally harmless and only cause binary
bloat. However if you have static members in an template like:
    PluginClassHandler<CompositeScreen,CompScreen,N>::mIndex
then that static variable also gets multiple separate instances. And the
version that a plugin uses depends entirely on the shared library load order
and load flags.

With clang, the OpenGL plugin was getting its own copy of the Composite
templates resulting in crash LP: #1065815. This is because clang compiles
mIndex to be a weak linkage symbol, so the dynamic loader at runtime chooses
which version to use. The crash does not happen with GCC because it compiles
mIndex to be a "unique" symbol (GNU extension), automatically avoiding
such duplicate problems.

More generally this possibly explains some crashes we see in and
around PluginClassHandler when plugins are toggled in CCSM. Although there
may be other templates that need similar fixes yet to resolve those.

3407. By Daniel van Vugt on 2012-10-08

Fix leakage of destroyed_pixmaps_table, containing pointers to freed decor_t's
which could result in a freed GHashTable being passed into g_hash_table_remove
and causing a crash.
(LP: #1060171)

3406. By Sam Spilsbury on 2012-10-02

Disable failing tests due to distro patch (LP: #1058577)

As discussed with didrocks, we cannot remove the primary_is_control.patch distro patch for the sake of fixing failing tests, so this just disables those tests from running on the stable branch so that we can get CI green there again.

We cannot merge https://code.launchpad.net/~compiz-team/compiz/compiz.fix_1058577/+merge/127104 for the reason above

Merge lp:~compiz-team/compiz/compiz.0.9.8.disable_failing_tests_due_to_distro_patch into lp:compiz/0.9.8

3405. By Łukasz Zemczak on 2012-10-02

Bump the core ABI number. The ABI itself is unchanged so we really shouldn't.
However distro insists.

3404. By Timo Jyrinki on 2012-09-30

Remove the non-used launchers and migration for them. Fixes a crash of g-c-c
when entering Keyboard section. (LP: #1057955)

3403. By Daniel van Vugt on 2012-09-27

Bump version to 0.9.8.5 until 0.9.8.6 is ready.

3402. By Daniel van Vugt on 2012-09-27

Update NEWS with latest bug fixes.

3401. By Daniel van Vugt on 2012-09-27

Some decoration pixmaps get leaked on window resize, due to race conditions
between gtk-window-decorator and the decor plugin.

That's a complex problem which requires a better interprocess communication
and resource ownership design. So I'm not trying to fix that directly.

Instead, what this does is limits pixmap leaks to the lifetime of the frame
window. So if any leaks do occur, they will be cleaned up and freed next
time the window is minimized or closed. Or to garbage collect for all windows,
just hit Ctrl+Alt+D twice.

(LP: #1057263)
. Fixes: https://bugs.launchpad.net/bugs/1057263. Approved by Sam Spilsbury.