Merge lp://qastaging/~mc.../inkscape/mc-selection-transform into lp://qastaging/~inkscape.dev/inkscape/trunk

Proposed by Mc
Status: Needs review
Proposed branch: lp://qastaging/~mc.../inkscape/mc-selection-transform
Merge into: lp://qastaging/~inkscape.dev/inkscape/trunk
Diff against target: 3772 lines (+882/-872)
3 files modified
src/selection-chemistry.cpp (+865/-872)
src/selection.cpp (+7/-0)
src/selection.h (+10/-0)
To merge this branch: bzr merge lp://qastaging/~mc.../inkscape/mc-selection-transform
Reviewer Review Type Date Requested Status
Jabiertxof code Approve
Review via email: mp+269893@code.qastaging.launchpad.net

Description of the change

Refactoring of sp_selection_apply_affine, taking care of the case when we select an original and a clone which is present in a selected group (and not directly selected)

To post a comment you must log in.
Revision history for this message
Mc (mc...) wrote :

NB: The diff is huge because i made a clang-format to have all the presentation right, the only non-whitespace parts are lines 1297-1651 and 3728+

Revision history for this message
Jabiertxof (jabiertxof) wrote :

I put three minor things about coding style previouly someone review me. AlsoNathan ping me about dont "clangformat" merges, till become accepted. Anyway I read your comment and help me a lot in the review. I do not a usage review, ping me if you want me to compile to give a second try.

review: Approve (code)

Unmerged revisions

14347. By Mc

more clang-format because i can never get the spacing right

14346. By Mc

final comments and refactor

14345. By Mc

refactor + fixed linked offsets

14344. By Mc

I was not /that/ far yesterday at 4am. Ready to be tested !

14343. By Mc

works better than previously, but there is still some strange behavior

14342. By Mc

Wait a minute, is that really working ? Have those several hours with paper and pen, filling pages with matrix multiplications, not been in vain ?

Just kidding, still WIP. make a clone of clone, move the original and first clone, the second moves unexpectedly.

But still, the fact that the first clone behaves right is already pretty cool !

14341. By Mc

I'm so confused right now.

14340. By Mc

does not break anything yet. I still have to fix the case where i resize a (original+(clone in a group)) selection

14339. By Mc

clang-format src/selection-chemistry.cpp

14338. By Mc

add includes_deeply helper function to test if an object is selected, even indirectly

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.