Pithos

Merge lp://qastaging/~mcg/pithos/disablescreensaver into lp://qastaging/~kevin-mehall/pithos/trunk

disablescreensaver
Merge into trunk

Proposed by Matthew Gregg on 2010-10-27

Status:	Needs review
Proposed branch:	lp://qastaging/~mcg/pithos/disablescreensaver
Merge into:	lp://qastaging/~kevin-mehall/pithos/trunk
Diff against target:	162 lines (+89/-5) 4 files modified .bzrignore (+1/-0) data/ui/PreferencesPithosDialog.ui (+21/-5) pithos/PreferencesPithosDialog.py (+3/-0) pithos/plugins/disable_screensaver.py (+64/-0)
To merge this branch:	bzr merge lp://qastaging/~mcg/pithos/disablescreensaver
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Kevin Mehall		2010-10-27	Needs Information on 2010-10-29
Review via email: mp+39418@code.qastaging.launchpad.net

Description of the change

This is another plugin I used in Rhythmbox and wanted to have available in Pithos. It will inhibit the Gnome screensaver while Pithos is playing and uninhibit while paused.

Revision history for this message

Kevin Mehall (kevin-mehall) wrote on 2010-10-29:

Thanks for your patch.

Can you give me an example of the use case? Since Pithos is audio-only, I don't think we need to keep the screen on as would a video app. The closest I can think of is if you wanted to keep the computer from going to sleep if you're listening to Pithos while doing non-computer work, but then it might be nice to allow the display to sleep and just inhibit power management in case you're on battery.

review: Needs Information

Revision history for this message

Matthew Gregg (mcg) wrote on 2010-10-30:

My personal use case is a combination of my previous plugin and this one. If Pithos is running and playing music I don't want my screensaver starting and if it does start(because I have locked my screen manually), to have the music pause. This is so I can have music while am working at the machine and not stopped if I walk away for a bit, but can still manually lock the screen and have the music pause. I would also use this plugin to implement a "party mode" when I want Pithos full screen and screensaver disabled. Now that you mention power management, true, you may not want to enable this on battery(I would since I would almost always manually lock screen or pause playback when I walk away from my laptop) and actually I am not sure this will stop the power manager from shutting down the display even with the screensaver disabled. Do they work independently with power manager trumping screensaver??