Charm Helpers

Merge lp://qastaging/~mew/charm-helpers/private-ip into lp://qastaging/charm-helpers

  1. private-ip
  2. Merge into devel
Proposed by Matthew Wedgwood
Status: Merged
Approved by: Haw Loeung
Approved revision: 14
Merged at revision: 19
Proposed branch: lp://qastaging/~mew/charm-helpers/private-ip
Merge into: lp://qastaging/charm-helpers
Diff against target: 31 lines (+10/-0)
2 files modified
charmhelpers/core/hookenv.py (+4/-0)
tests/core/test_hookenv.py (+6/-0)
To merge this branch: bzr merge lp://qastaging/~mew/charm-helpers/private-ip
Reviewer Review Type Date Requested Status
Haw Loeung Approve
Matthew Wedgwood (community) Needs Fixing
Review via email: mp+166731@code.qastaging.launchpad.net

Commit message

Provide an easy way to get the unit's IP

Description of the change

Provide an easy way to get the unit's IP

To post a comment you must log in.
Revision history for this message
Haw Loeung (hloeung) wrote :

Looks good to me, +1

review: Approve
Revision history for this message
Matthew Wedgwood (mew) wrote :

-1, try harder.

Should use the existing "unit_get" python function rather than calling out to "unit-get"

review: Needs Fixing
lp://qastaging/~mew/charm-helpers/private-ip updated
15. By Matthew Wedgwood

Use existing unit_get function

Revision history for this message
Haw Loeung (hloeung) wrote :

Looks good, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches