Merge lp://qastaging/~mew/juju-deployer/uncomplicate-relations into lp://qastaging/~gandelman-a/juju-deployer/trunk
Proposed by
Matthew Wedgwood
| Status: | Merged |
|---|---|
| Approved by: | Adam Gandelman |
| Approved revision: | 66 |
| Merged at revision: | 67 |
| Proposed branch: | lp://qastaging/~mew/juju-deployer/uncomplicate-relations |
| Merge into: | lp://qastaging/~gandelman-a/juju-deployer/trunk |
| Diff against target: |
40 lines (+2/-28) 1 file modified
deployer.py (+2/-28) |
| To merge this branch: | bzr merge lp://qastaging/~mew/juju-deployer/uncomplicate-relations |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| James Page (community) | Approve | ||
| Adam Gandelman | Pending | ||
|
Review via email:
|
|||
Description of the change
This change removes the complicated interface-guessing logic from deployer.py. Relation names are now passed directly to juju add-relation.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I've not tested this (but I know adam has) but I'm completely a +1 on this.
It will start to flush out where charms have bad interface typing as well which is good.