Merge lp://qastaging/~mhaulo/mixxx/allow-playlist-and-crate-renaming into lp://qastaging/~mixxxdevelopers/mixxx/trunk
Proposed by
Mika Haulo
Status: | Merged |
---|---|
Merge reported by: | RAFFI TEA |
Merged at revision: | not available |
Proposed branch: | lp://qastaging/~mhaulo/mixxx/allow-playlist-and-crate-renaming |
Merge into: | lp://qastaging/~mixxxdevelopers/mixxx/trunk |
Diff against target: |
274 lines (+150/-0) 8 files modified
mixxx/src/library/cratefeature.cpp (+52/-0) mixxx/src/library/cratefeature.h (+2/-0) mixxx/src/library/dao/cratedao.cpp (+19/-0) mixxx/src/library/dao/cratedao.h (+1/-0) mixxx/src/library/dao/playlistdao.cpp (+21/-0) mixxx/src/library/dao/playlistdao.h (+2/-0) mixxx/src/library/playlistfeature.cpp (+51/-0) mixxx/src/library/playlistfeature.h (+2/-0) |
To merge this branch: | bzr merge lp://qastaging/~mhaulo/mixxx/allow-playlist-and-crate-renaming |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Good | Abstain | ||
RAFFI TEA | Approve | ||
Review via email:
|
Description of the change
This is a fix proposal for wishlist bug #661461: Allow playlist and crate renaming (https:/
To post a comment you must log in.
Hey Mika,
thank you very much for your contribution. I have reviewed your branch and found a bug: Assume you have two playlists "A" and "B". Renaming "B" to "A" will not fail and results in two playlists "A" and "A". Therefore, you must check if the renamed playlist name exists or not. Furthermore, I would like see an UNIQUE constraint on attribute <name> in the <playlist table> (if other developers agree).
@Albert & Developers
I've done a lot of library improvements in my Traktor branch, e.g., n-level tree-structures for child models. If we gonna merge his branch to trunk first, we end up in numerous conflicts when merging Traktor feature in. I recommend to merge his breach into the Traktor feature branch.