lp://qastaging/~mhlavink/ecryptfs/20090424

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://qastaging/~ecryptfs/ecryptfs/ecryptfs-utils

Dustin Kirkland : Approve on 2009-04-30

Diff: None lines api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

386. By Michal Hlavinka on 2009-04-23

decision_graph.c: fix uninitialized return code

Werror build complains about decision_graph.c:375:
warning: 'rc' may be used uninitialized in this function. It's true,
firs assigment to rc can be bypassed with goto out.

Signed-off-by: Michal Hlavinka <email address hidden>

385. By Michal Hlavinka on 2009-04-23

mount.ecryptfs.c: don't pass verbosity option to kernel

verbosity option should not be passed to kernel module,
because kernel module doesn't know about it and produces
unnecessary lines in logs

Signed-off-by: Michal Hlavinka <email address hidden>

384. By Dustin Kirkland  on 2009-04-23

 388. By Michal Hlavinka 17 hours ago

    key_management.c: if key is already in keyring don't report it as error

    ecryptfs_add_passphrase_key_to_keyring gets return code 1 if key,
    it is trying to add to keyring, already exists in keyring.
    Return code remains 1, just don't report it as error.

    Signed-off-by: Michal Hlavinka <email address hidden>
387. By Michal Hlavinka 18 hours ago

    check and fix asprintf's error codes

    Change all MOUNT_ERROR return codes for asprintf failure to -ENOMEM.
    Make sure all return codes are reset to zero or overwritten,
    because asprintf doesn't return zero for success.

    Signed-off-by: Michal Hlavinka <email address hidden>

Acked-by: Dustin Kirkland <email address hidden>

383. By Dustin Kirkland  on 2009-04-22

don't do the automatic version bump just yet in the release script

Signed-off-by: Dustin Kirkland <email address hidden>

382. By Dustin Kirkland  on 2009-04-22

improve release script to support tagging

Signed-off-by: Dustin Kirkland <email address hidden>

381. By Dustin Kirkland  on 2009-04-22

install ecryptfs-record-passphrase file in /usr/share/ecryptfs-utils

Signed-off-by: Dustin Kirkland <email address hidden>

380. By Dustin Kirkland  on 2009-04-21

fix build break

add ecryptfs-dot-private appropriately

Signed-off-by: Dustin Kirkland <email address hidden>

379. By Dustin Kirkland  on 2009-04-21

bump version to 74 for rc testing

Signed-off-by: Dustin Kirkland <email address hidden>

378. By Dustin Kirkland  on 2009-04-21

Changelogs updated.

Signed-off-by: Dustin Kirkland <email address hidden>

377. By Dustin Kirkland  on 2009-04-21

Merge from Michal Hlavinka.

386. By Michal Hlavinka 2 hours ago

    change error codes to be more descriptive

    Error codes were changed to be more descriptive. MOUNT_ERROR after
    asprintf changed to ENOMEM, some error codes are no longer filtered
    to MOUNT_ERROR. And some other changes mostly from general MOUNT_ERROR
    to ESOMETHING.

    Signed-off-by: Michal Hlavinka <email address hidden>
385. By Michal Hlavinka 3 hours ago

    decision_graph.h, *: change definition of node return codes to positive values

    Using negative node return codes and negative error codes brings
    too big complications everywhere. Use positive values for node return codes.
    Change error codes that were changed to positive values back to negative
    values.

    Signed-off-by: Michal Hlavinka <email address hidden>
384. By Michal Hlavinka 3 hours ago

    mount.ecryptfs.c: insist for yes/no answer for unkown sigs

    Mounting with new uknown sig is important question. Insist on yes/no
    answer. Don't assume everything else than yes is no.

    Signed-off-by: Michal Hlavinka <email address hidden>
383. By Michal Hlavinka 4 hours ago

    don't print error for removing key from keyring if it succeeded

    Prevent printing of "Failed to remove ... with sig [...] from keyring: Success"

    Signed-off-by: Michal Hlavinka <email address hidden>
382. By Michal Hlavinka 4 hours ago

    module_mgr.c: insist on yes/no answer

    Insist on yes/no/y/n answer. Don't assume everything starting 'y'
    is yes and everything else is no. If wrong anser, return
    WRONG_VALUE for asking again.

    Signed-off-by: Michal Hlavinka <email address hidden>
381. By Michal Hlavinka 4 hours ago

    use ECRYPTFS_NONEMPTY_VALUE_REQUIRED where reasonable

    Some empty values makes no sense. Require nonempty values
    in that case (for interactive mount).

    Signed-off-by: Michal Hlavinka <email address hidden>
380. By Michal Hlavinka 5 hours ago

    pam_ecryptfs.c: don't try to unwrap key for users not using pam mounting

    Don't delay passphrase verification for users not using pam automounting.

    Signed-off-by: Michal Hlavinka <email address hidden>
379. By Michal Hlavinka 5 hours ago

    add verbosity to man page

    Added notes about verbosity to ecryptfs man page.

    Signed-off-by: Michal Hlavinka <email address hidden>
378. By Michal Hlavinka 5 hours ago

    decision_graph.* : add ECRYPTFS_NONEMPTY_VALUE_REQUIRED flag for nodes

    Nodes can prevent future problems asking for non-empty value.

    Signed-off-by: Michal Hlavinka <email address hidden>
377. By Michal Hlavinka 11 hours ago

    decision_graph.* : add WRONG_VALUE return code to nodes for asking question again

    Failing mount because of typo is not nice. If node transaction function returns
    WRONG_VALUE and we can ask questions (verbosity=0 is not specified),
    ask question again.

    Signed-off-by: Michal Hlavinka <email address hidden>

Acked-by: Dustin Kirkland <email address hidden>