BAMF

Merge lp://qastaging/~mhr3/bamf/non-chatty-signals into lp://qastaging/bamf/0.4

  1. non-chatty-signals
  2. Merge into 0.4
Proposed by Michal Hruby
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 465
Merged at revision: 430
Proposed branch: lp://qastaging/~mhr3/bamf/non-chatty-signals
Merge into: lp://qastaging/bamf/0.4
Prerequisite: lp://qastaging/~3v1n0/bamf/libbamf-net-dbus-hints
Diff against target: 453 lines (+220/-26)
4 files modified
src/bamf-application.c (+4/-8)
src/bamf-application.h (+2/-2)
src/bamf-matcher.c (+207/-16)
src/org.ayatana.bamf.xml (+7/-0)
To merge this branch: bzr merge lp://qastaging/~mhr3/bamf/non-chatty-signals
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+88462@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2012-01-13.

Description of the change

Added method and signal to list desktop file paths of running applications, this is needed for application lens, which should exclude running applications from the default results and we need to minimize the number of wakeups of the lens daemon.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Looks good to me.

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The prerequisite lp:~3v1n0/bamf/libbamf-net-dbus-hints has not yet been merged into lp:bamf.

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

This looks awesome, just one thing:

  192 + priv->idle_cb_id = g_idle_add (emit_paths_changed, self);

Can you make this a longer timeout? There's no point in guaranteeing super fine granularity in the updates when we have a signal suitable for batching. I am thinking 200ms or maybe as much as 500ms...

review: Needs Fixing
Revision history for this message
Michal Hruby (mhr3) wrote :

Changed the idle to 500ms timeout.

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Likes!

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The prerequisite lp:~3v1n0/bamf/libbamf-net-dbus-hints has not yet been merged into lp:bamf.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Please fix the small conflict that this branch has with newest trunk, then it's ready to go in! :)

review: Needs Fixing
lp://qastaging/~mhr3/bamf/non-chatty-signals updated
465. By Michal Hruby

Merge trunk

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches