dee

Merge lp://qastaging/~mhr3/dee/fix-1091313 into lp://qastaging/dee

  1. fix-1091313
  2. Merge into trunk
Proposed by Michal Hruby
Status: Merged
Approved by: Francis Ginther
Approved revision: 396
Merged at revision: 396
Proposed branch: lp://qastaging/~mhr3/dee/fix-1091313
Merge into: lp://qastaging/dee
Diff against target: 63 lines (+39/-0)
1 file modified
src/dee-proxy-model.c (+39/-0)
To merge this branch: bzr merge lp://qastaging/~mhr3/dee/fix-1091313
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Paweł Stołowski (community) Approve
Review via email: mp+140241@code.qastaging.launchpad.net

Commit message

Fix performance issue when using sorted DeeSharedModel

Description of the change

Override find/insert_sorted implementation in DeeProxyModel, so it doesn't fallback to the implementation in DeeSerializableModel which is using much slower implementation ( O(N) vs O(log(N) /for DeeSequenceModel/ ).

To post a comment you must log in.
Revision history for this message
Paweł Stołowski (stolowski) wrote :

LGTM. +1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/dee-mbs-autolanding/26/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=amd64/26/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=i386/26/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad (maybe a permission problem?).
http://jenkins.qa.ubuntu.com/job/dee-mbs-autolanding/26/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=amd64/26/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=i386/26/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:396
http://jenkins.qa.ubuntu.com/job/dee-mbs-ci/7/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-mbs-ci/./build=pbuilder,distribution=quantal,flavor=amd64/7/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-mbs-ci/./build=pbuilder,distribution=quantal,flavor=i386/7/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/dee-mbs-ci/7//rebuild/?

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/dee-mbs-autolanding/27/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=amd64/27/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=i386/27/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad (maybe a permission problem?).
http://jenkins.qa.ubuntu.com/job/dee-mbs-autolanding/27/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=amd64/27/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=i386/27/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Re-approving to attempt to autoland again. Not sure why the earlier attempts failed as the revid appears to have been set at the time the job ran. Perhaps this was the victim of yesterday's jenkins outage.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/dee-mbs-autolanding/28/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=amd64/28/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=i386/28/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad (maybe a permission problem?).
http://jenkins.qa.ubuntu.com/job/dee-mbs-autolanding/28/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=amd64/28/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=i386/28/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

On a second look, the jenkins job was misconfigured, it was forcing the autolanding to fail. Unfortunately, I can't explain why. The job has been fixed and double checked against other similar jobs. Re-approving.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: