dee

Merge lp://qastaging/~mhr3/dee/floating-and-sinking into lp://qastaging/dee

  1. floating-and-sinking
  2. Merge into trunk
Proposed by Michal Hruby
Status: Merged
Approved by: Mikkel Kamstrup Erlandsen
Approved revision: 338
Merged at revision: 337
Proposed branch: lp://qastaging/~mhr3/dee/floating-and-sinking
Merge into: lp://qastaging/dee
Diff against target: 106 lines (+24/-6)
4 files modified
src/dee-serializable.c (+13/-4)
vapi/Dee-1.0-custom.vala (+7/-0)
vapi/Dee-1.0.metadata (+1/-0)
vapi/dee-1.0.vapi (+3/-2)
To merge this branch: bzr merge lp://qastaging/~mhr3/dee/floating-and-sinking
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+88644@code.qastaging.launchpad.net

Description of the change

Since dee_serializable_serialize is a virtual method, it has to return a non-floating reference to make sure it works in all cases without memory leaks.

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Agreed with the analysis in bug #916783. Let's get this in.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: