dee

Merge lp://qastaging/~mhr3/dee/introspectable-sort-methods into lp://qastaging/dee

  1. introspectable-sort-methods
  2. Merge into trunk
Proposed by Michal Hruby
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 376
Merged at revision: 376
Proposed branch: lp://qastaging/~mhr3/dee/introspectable-sort-methods
Merge into: lp://qastaging/dee
Diff against target: 418 lines (+289/-6)
5 files modified
bindings/python/Dee.py (+20/-1)
src/dee-model.c (+98/-0)
src/dee-model.h (+37/-5)
tests/test-model-rows.c (+130/-0)
vapi/dee-1.0.vapi (+4/-0)
To merge this branch: bzr merge lp://qastaging/~mhr3/dee/introspectable-sort-methods
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
Review via email: mp+118801@code.qastaging.launchpad.net

Commit message

Make the *sorted methods usable with introspection

Description of the change

Dee's find_sorted and insert_sorted were not usable from introspectable languages.

Added a delegate that's introspection friendly and tests that make sure it's working.

To post a comment you must log in.
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Looks, good. Just one question:
30 + # FIXME: perhaps override __eq__ on ModelIter?
is this still applicable?

review: Needs Information
lp://qastaging/~mhr3/dee/introspectable-sort-methods updated
376. By Michal Hruby

Remove fixed FIXME

Revision history for this message
Michal Hruby (mhr3) wrote :

> Looks, good. Just one question:
> 30 + # FIXME: perhaps override __eq__ on ModelIter?
> is this still applicable?

Right, already fixed.

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Looks good, tests pass.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: