dee

Merge lp://qastaging/~mhr3/dee/vala-tags into lp://qastaging/dee

  1. vala-tags
  2. Merge into trunk
Proposed by Michal Hruby
Status: Merged
Approved by: Mikkel Kamstrup Erlandsen
Approved revision: 331
Merged at revision: 331
Proposed branch: lp://qastaging/~mhr3/dee/vala-tags
Merge into: lp://qastaging/dee
Diff against target: 107 lines (+34/-12)
3 files modified
vapi/Dee-1.0-custom.vala (+20/-6)
vapi/Dee-1.0.metadata (+4/-0)
vapi/dee-1.0.vapi (+10/-6)
To merge this branch: bzr merge lp://qastaging/~mhr3/dee/vala-tags
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+87439@code.qastaging.launchpad.net

Description of the change

Makes ModelTag fully usable from Vala.

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

The new way to use ModelTag is now:

var tag = new Dee.ModelTag<string> (model);
tag[model, iter] = "weeeee";
debug ("%s", tag[model, iter]);
tag.clear (model, iter);

Note that this will now properly duplicate the string.

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Nice! :-)

But - This will break libunity, no? If so please have a branch ready for libunity before we merge.

review: Needs Information
Revision history for this message
Michal Hruby (mhr3) wrote :

Right - here is it: https://code.launchpad.net/~mhr3/libunity/new-tag-api/+merge/87445

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: