Merge lp://qastaging/~mhr3/libunity/remote-scope-sources into lp://qastaging/libunity

Proposed by Michal Hruby
Status: Merged
Approved by: Mikkel Kamstrup Erlandsen
Approved revision: 113
Merged at revision: 112
Proposed branch: lp://qastaging/~mhr3/libunity/remote-scope-sources
Merge into: lp://qastaging/libunity
Diff against target: 232 lines (+137/-5)
5 files modified
src/unity-lens-filters.vala (+22/-1)
src/unity-scope-proxy-remote.vala (+1/-0)
src/unity-scope.vala (+1/-2)
test/vala/test-lens.vala (+71/-2)
test/vala/test-remote-scope.vala (+42/-0)
To merge this branch: bzr merge lp://qastaging/~mhr3/libunity/remote-scope-sources
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+89417@code.qastaging.launchpad.net

Description of the change

Fix sources filter when using remote scopes.

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

68 - public OptionsFilter sources { get; internal set; }
69 + public OptionsFilter sources { get; private set; }

Technicaly this is an ABI break. Although only in internal ABI. If it's just a cleanup I suggest we leave it as is to not trigger the alarm bells of the packaging system.

$ nm -D src/.libs/libunity.so | grep set_sources
0001d931 T unity_lens_set_sources_display_name
000483ac T unity_scope_proxy_set_sources
$ nm -D /usr/lib/libunity.so | grep set_sources
00017140 T unity_lens_set_sources_display_name
00037c80 T unity_scope_proxy_set_sources
0002d350 T unity_scope_set_sources

review: Needs Fixing
113. By Michal Hruby

Revert ABI break

Revision history for this message
Michal Hruby (mhr3) wrote :

Reverted, unfortunately "internal set;" marks the property as writeable, which is not desired.

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Point taken. If you want to remove it take it up with Didier. It's unlikely to be an issue; we just need to make sure nobody panics ;-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches