Merge lp://qastaging/~mhr3/libunity/search-on-view into lp://qastaging/libunity

Proposed by Michal Hruby
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 125
Merged at revision: 124
Proposed branch: lp://qastaging/~mhr3/libunity/search-on-view
Merge into: lp://qastaging/libunity
Diff against target: 89 lines (+41/-1)
3 files modified
src/unity-scope-factory.vala (+1/-0)
src/unity-scope.vala (+10/-0)
test/vala/test-lens.vala (+30/-1)
To merge this branch: bzr merge lp://qastaging/~mhr3/libunity/search-on-view
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Review via email: mp+96201@code.qastaging.launchpad.net

Commit message

Queue a global search when scope is initialized

Description of the change

Unity currently doesn't send a GlobalSearch() call with empty search string to the lenses when the dash is shown, and this causes that for example files lens doesn't display anything until you search for something. But it does send a SetViewType() call, so this branch queues an empty search on init so results will be displayed when the dash is shown.

Added test to make sure initial SetViewCall() fires a search.

UNBLOCK

To post a comment you must log in.
125. By Michal Hruby

No need to expose the prepare_search method

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Looks good and all tests pass. Approving!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches