Merge lp://qastaging/~mhr3/libzeitgeist/data-source-registry into lp://qastaging/libzeitgeist
Proposed by
Michal Hruby
| Status: | Merged |
|---|---|
| Approved by: | Mikkel Kamstrup Erlandsen |
| Approved revision: | 151 |
| Merged at revision: | 149 |
| Proposed branch: | lp://qastaging/~mhr3/libzeitgeist/data-source-registry |
| Merge into: | lp://qastaging/libzeitgeist |
| Diff against target: |
2120 lines (+1715/-118) 18 files modified
bindings/zeitgeist-1.0.gi (+186/-0) bindings/zeitgeist-1.0.metadata (+8/-0) bindings/zeitgeist-1.0.vapi (+32/-0) doc/reference/zeitgeist-1.0-docs.sgml (+3/-1) doc/reference/zeitgeist-1.0-sections.txt (+163/-107) doc/reference/zeitgeist-1.0.types (+8/-6) src/Makefile.am (+12/-0) src/marshal.list (+4/-0) src/org.gnome.zeitgeist.Log.xml (+73/-0) src/zeitgeist-data-source-registry.c (+527/-0) src/zeitgeist-data-source-registry.h (+108/-0) src/zeitgeist-data-source.c (+349/-0) src/zeitgeist-data-source.h (+101/-0) src/zeitgeist-eggdbusconversions.c (+51/-0) src/zeitgeist-eggdbusconversions.h (+8/-2) src/zeitgeist.h (+3/-1) tests/Makefile.am (+2/-0) tests/test-eggdbusconversions.c (+77/-1) |
| To merge this branch: | bzr merge lp://qastaging/~mhr3/libzeitgeist/data-source-registry |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mikkel Kamstrup Erlandsen | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2010-07-22.
Description of the change
Adds API which talks to the DataSourceRegistry extension.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Outstanding work Michal! A few comments, but nothing critical:
1) There is a comment "... coming from this Index instance ..." which should probably be s/Index/data source registry/
2) You need a line break after the symbol name in the docstring for zeitgeist_
3) Can you add a bit of documentation to the ZeitgeistDataSource section?
4) Can you document that you are stealing the ref to the GPtrArray in zeitgeist_
5) I prefer that getters returning booleans are named as foo_is_*(). This affects zeitgeist_
6) Please add some unit tests for the conversion between the eggdbus stuff and the native types
7) Integrate the two new types into the gtk-doc
If you fix this I'd be delighted to merge you branch :-)
And as a bonus you could perhaps add some more doc strings, but it's ok if you don't...