Merge lp://qastaging/~mhr3/libzeitgeist/fix-reconnect into lp://qastaging/libzeitgeist
Proposed by
Michal Hruby
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 212 | ||||
| Proposed branch: | lp://qastaging/~mhr3/libzeitgeist/fix-reconnect | ||||
| Merge into: | lp://qastaging/libzeitgeist | ||||
| Diff against target: |
164 lines (+56/-24) 1 file modified
src/zeitgeist-log.c (+56/-24) |
||||
| To merge this branch: | bzr merge lp://qastaging/~mhr3/libzeitgeist/fix-reconnect | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mikkel Kamstrup Erlandsen | Approve | ||
|
Review via email:
|
|||
Description of the change
A little bit of clarification - at first I went without the private is_connected member and I was calling g_object_notify (..., "connected") in the ..._appearead and ..._vanished callbacks, but it turned out that the g-name-owner property isn't yet updated when that callback is being processed, therefore zg might have been killed, and you would get a notification, but calling is_connected () would return TRUE.
Therefore I just added the private member and am updating everything in the name_owner_changed callback.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good