libzeitgeist

Merge lp://qastaging/~mhr3/libzeitgeist/libzg-mimetypes-import into lp://qastaging/libzeitgeist

  1. libzg-mimetypes-import
  2. Merge into trunk
Proposed by Michal Hruby
Status: Merged
Merged at revision: 171
Proposed branch: lp://qastaging/~mhr3/libzeitgeist/libzg-mimetypes-import
Merge into: lp://qastaging/libzeitgeist
Diff against target: 659 lines (+418/-213)
3 files modified
src/zeitgeist-mimetypes.c (+94/-213)
tools/mimetypes2c.py (+88/-0)
tools/zeitgeist-mimetypes.template (+236/-0)
To merge this branch: bzr merge lp://qastaging/~mhr3/libzeitgeist/libzg-mimetypes-import
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen Approve
Review via email: mp+34649@code.qastaging.launchpad.net

Description of the change

Adds the ability to generate the zeitgeist-mimetypes source file using the data from Zeitgeist's mimetypes module.

To post a comment you must log in.
Revision history for this message
Seif Lotfy (seif) wrote :

What is the major difference in zeitgeist-mimetypes.c? Should that not be replaced or depend on the mimetypes2c ?

Revision history for this message
Seif Lotfy (seif) wrote :

> What is the major difference in zeitgeist-mimetypes.c? Should that not be
> replaced or depend on the mimetypes2c ?

OK understood it now! Forget this comment! Good Job!

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Sorry for not reacting earlier, I was very tied up this week. Will look on it Monday!

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Very much sorry for the delay! As always, good work Michal! Approved!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches