Merge lp://qastaging/~mhr3/libzeitgeist/various-fixes into lp://qastaging/libzeitgeist

Looks good I think. Could you elaborate a bit on what the intention of these fixes are?

Also; the primary goal seems to be adding the ZeitgeistMonitor API, but why do you need the EggZeitgeistMonitor? It's not an exported symbol of the lib (just an impl detail)...

Yes, primary goal is addition of ZeitgeistMonitor, other than that there are fixes so now all ZeitgeistLog methods should be usable (and leak-free) in Vala.

As for EggZeitgeistMonitor, I had to define it, cause the introspection finds that ZeitgeistMonitor implements it and without the dummy definition it's not possible to generate the vapi, still it's defined as empty interface - so also just an impl detail.

The only issue is that the vapi was generated using git vapigen and the insert_events_from_ptrarray method will only work with git Vala, but once 0.8.2 is released, it will be fine.

One more thing before I merge. How about changing the signature of Log.insert_events_from_ptrarray() from your new:

 zeitgeist_log_insert_events_from_ptrarray (ZeitgeistLog *self,
                                            GCancellable *cancellable,
                                            GPtrArray *events,
                                            GAsyncReadyCallback callback,
                                            gpointer user_data);

to:

 zeitgeist_log_insert_events_from_ptrarray (ZeitgeistLog *self,
                                            GPtrArray *events,
                                            GCancellable *cancellable,
                                            GAsyncReadyCallback callback,
                                            gpointer user_data);

Ie. making 'events' the second arg. That way the signature is consistent with how GIO does it. See fx. g_output_stream_write_async().

Sorry for the fuzz! :-)

Yep, I missed that, fixed and pushed.

Merged. Thanks a bunch for your hard work!