Merge lp://qastaging/~mhr3/libzeitgeist/various-fixes into lp://qastaging/libzeitgeist
Proposed by
Michal Hruby
| Status: | Merged |
|---|---|
| Merge reported by: | Mikkel Kamstrup Erlandsen |
| Merged at revision: | not available |
| Proposed branch: | lp://qastaging/~mhr3/libzeitgeist/various-fixes |
| Merge into: | lp://qastaging/libzeitgeist |
| Diff against target: |
47 lines (+11/-3) 2 files modified
bindings/zeitgeist-1.0.metadata (+1/-0) src/zeitgeist-eggdbusconversions.c (+10/-3) |
| To merge this branch: | bzr merge lp://qastaging/~mhr3/libzeitgeist/various-fixes |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mikkel Kamstrup Erlandsen | make check, and code review | Approve | |
|
Review via email:
|
|||
Description of the change
Fixes memory leak in conversion from ZeitgeistEvent to EggZeitgeistEvent.
Another thing to consider is ref sinking the events created in call to ie find_events_finish, should this be done? Basically they can be considered as owned by the PtrArray, so I think it makes sense.
To post a comment you must log in.
Revision history for this message
| Mikkel Kamstrup Erlandsen (kamstrup) wrote | # |
review:
Approve
(make check, and code review)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Good spot! Thanks a bunch!