libzeitgeist

Merge lp://qastaging/~mhr3/libzeitgeist/various-fixes into lp://qastaging/libzeitgeist

various-fixes
Merge into trunk

Proposed by Michal Hruby on 2011-07-11

Status:

Merged

Merged at revision:

208

Proposed branch:

lp://qastaging/~mhr3/libzeitgeist/various-fixes

Merge into:

lp://qastaging/libzeitgeist

Diff against target:

245 lines (+58/-25)

5 files modified

src/zeitgeist-data-source-registry.c (+13/-7)
src/zeitgeist-data-source.c (+4/-2)
src/zeitgeist-event.c (+28/-15)
src/zeitgeist-index.c (+2/-1)
src/zeitgeist-log.c (+11/-0)

To merge this branch:

bzr merge lp://qastaging/~mhr3/libzeitgeist/various-fixes

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Mikkel Kamstrup Erlandsen		2011-07-11	Approve on 2011-07-12
Review via email: mp+67606@code.qastaging.launchpad.net

Description of the change

Fixes two types of leaks:
1) Leak in the usage of g_variant_iter_loop, which is expected to run over whole collection and leaks if it doesn't. (leaks around 30bytes per each ZeitgeistEvent)
2) g_variant_get_child_value never returns a floating reference (it's a child, so the parent already has a ref), this caused pretty much the entire raw dbus data of every single event to leak.