Merge lp://qastaging/~mhr3/unity-lens-applications/camelcase-friendly-index into lp://qastaging/unity-lens-applications

Proposed by Michal Hruby
Status: Merged
Approved by: Mikkel Kamstrup Erlandsen
Approved revision: 263
Merged at revision: 261
Proposed branch: lp://qastaging/~mhr3/unity-lens-applications/camelcase-friendly-index
Merge into: lp://qastaging/unity-lens-applications
Diff against target: 233 lines (+70/-28)
8 files modified
TESTS-TODO.txt (+3/-0)
configure.ac (+1/-0)
src/Makefile.am (+2/-2)
src/daemon.vala (+7/-13)
src/runner.vala (+1/-1)
src/unity-package-search.cc (+12/-2)
src/unity-ratings-db.c (+1/-1)
src/utils.vala (+43/-9)
To merge this branch: bzr merge lp://qastaging/~mhr3/unity-lens-applications/camelcase-friendly-index
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+89926@code.qastaging.launchpad.net

Description of the change

Split CamelCase words from application names before feeding them to xapian, which allows us to search for any part of the name.

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Looks good and manual testing confirms that this works. Before I approve it can you queue a testcase in TESTS-TODO.txt?

review: Needs Fixing
Revision history for this message
Michal Hruby (mhr3) wrote :

Done.

263. By Michal Hruby

Add test desciption

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches