Merge lp://qastaging/~mhr3/unity-lens-applications/fix-841847 into lp://qastaging/unity-lens-applications
Proposed by
Michal Hruby
| Status: | Merged |
|---|---|
| Approved by: | Mikkel Kamstrup Erlandsen |
| Approved revision: | 263 |
| Merged at revision: | 262 |
| Proposed branch: | lp://qastaging/~mhr3/unity-lens-applications/fix-841847 |
| Merge into: | lp://qastaging/unity-lens-applications |
| Diff against target: |
166 lines (+54/-20) 2 files modified
configure.ac (+1/-1) src/daemon.vala (+53/-19) |
| To merge this branch: | bzr merge lp://qastaging/~mhr3/unity-lens-applications/fix-841847 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mikkel Kamstrup Erlandsen (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Allow selection of multiple categories in the type filter. UNBLOCK
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Tested against Unity trunk and works very well. I am not particularly keen on maintaining a dupe list of the filter ids, but it doesn't seem to be easily fixable without a major refactoring. Otherwise, the code looks great.
All in all, nice work!
(wrt testing - this branch is currently exceptionally hard to test in an automated manner. I took extra care in the review (and to some degree the branch can be considered a refactoring so I don't see big risk from this branch))