Merge lp://qastaging/~mhr3/unity-lens-applications/fix-842108 into lp://qastaging/unity-lens-applications
Proposed by
Michal Hruby
| Status: | Merged |
|---|---|
| Approved by: | Didier Roche-Tolomelli |
| Approved revision: | 285 |
| Merged at revision: | 285 |
| Proposed branch: | lp://qastaging/~mhr3/unity-lens-applications/fix-842108 |
| Merge into: | lp://qastaging/unity-lens-applications |
| Diff against target: |
210 lines (+100/-42) 3 files modified
src/runner.vala (+87/-42) tests/test-full-and-partial.sh (+7/-0) tests/test-no-partial-commands.sh (+6/-0) |
| To merge this branch: | bzr merge lp://qastaging/~mhr3/unity-lens-applications/fix-842108 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Didier Roche-Tolomelli | Approve | ||
|
Review via email:
|
|||
Commit message
Don't remove exact matches from list of suggestions
Description of the change
"Run command" lens doesn't include exact match when there are also partial matches.
Don't remove the exact match from list of suggestions and split out the searcher into a separate class to make it easier to unit test in the future.
Added unity-tool tests.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM, thanks Michal!