Merge lp://qastaging/~mhr3/unity-lens-music/rb-proper-album-handling into lp://qastaging/unity-lens-music
Proposed by
Michal Hruby
| Status: | Merged |
|---|---|
| Approved by: | Gord Allott |
| Approved revision: | 82 |
| Merged at revision: | 81 |
| Proposed branch: | lp://qastaging/~mhr3/unity-lens-music/rb-proper-album-handling |
| Merge into: | lp://qastaging/unity-lens-music |
| Diff against target: |
307 lines (+149/-30) 2 files modified
src/rhythmbox-collection.vala (+107/-11) src/rhythmbox-scope.vala (+42/-19) |
| To merge this branch: | bzr merge lp://qastaging/~mhr3/unity-lens-music/rb-proper-album-handling |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gord Allott (community) | Approve | ||
| Alex Launi (community) | code-only | Approve | |
|
Review via email:
|
|||
Commit message
Rhythmbox scope: Implement proper album handling
Description of the change
Clicking on music lens's rhythmbox album results plays only random song from the album instead of all songs from the album.
This branch implements proper album handling for rhythmbox, which was missing in the original merge when the scope was merged before beta2.
No tests, as this would require rhythmbox's database and we don't have the infrastructure setup for that. But FWIW this only builds on top of the data structures already present /and tested/ in the scope.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
+1. Looks fine, couldn't test it. RB doesn't work on my machine.