Unity Videos Lens

Merge lp://qastaging/~mhr3/unity-lens-video/fix-1079699 into lp://qastaging/unity-lens-video/remote-videos-scope-trunk

  1. fix-1079699
  2. Merge into remote-videos
Proposed by Michal Hruby
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 65
Merged at revision: 59
Proposed branch: lp://qastaging/~mhr3/unity-lens-video/fix-1079699
Merge into: lp://qastaging/unity-lens-video/remote-videos-scope-trunk
Diff against target: 79 lines (+10/-26)
1 file modified
src/unity-scope-video-remote (+10/-26)
To merge this branch: bzr merge lp://qastaging/~mhr3/unity-lens-video/fix-1079699
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
John Lenton (community) Approve
Review via email: mp+137786@code.qastaging.launchpad.net

Commit message

Ensure we query the videosearch server only when the data is needed

Description of the change

There was a bug in the remote video scope, which caused it to query the videosearch server every 5 minutes from non-US regions.

Ensure we query the videosearch server only when the data is needed.

To post a comment you must log in.
lp://qastaging/~mhr3/unity-lens-video/fix-1079699 updated
64. By Michal Hruby

Merge trunk

Revision history for this message
John Lenton (chipaca) wrote :

OK. Not sure I like the behaviour change, but I'm OK with it.

review: Approve
lp://qastaging/~mhr3/unity-lens-video/fix-1079699 updated
65. By Michal Hruby

Remove extra PreferencesManager call

Revision history for this message
Paweł Stołowski (stolowski) wrote :

75 + if not search.props.search_string.strip() and not sources and results:

Why 'not sources'?

review: Needs Information
Revision history for this message
Michal Hruby (mhr3) wrote :

> 75 + if not search.props.search_string.strip() and not sources and
> results:
>
> Why 'not sources'?

Cause we want to cache only empty, non-filtered search.

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Right. Ok, LGTM and works fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: