Unity Videos Lens

Merge lp://qastaging/~mhr3/unity-lens-video/fix-1226573 into lp://qastaging/unity-lens-video

fix-1226573
Merge into trunk

Proposed by Michal Hruby on 2013-09-17

Status:

Merged

Approved by:

Paweł Stołowski on 2013-09-18

Approved revision:

124

Merged at revision:

121

Proposed branch:

lp://qastaging/~mhr3/unity-lens-video/fix-1226573

Merge into:

lp://qastaging/unity-lens-video

Diff against target:

811 lines (+210/-355)

7 files modified

debian/control (+0/-1)
src/Makefile.am (+0/-1)
src/remote-scope.vala (+191/-273)
src/remote-uri.vala (+0/-52)
src/remote-video-main.vala (+11/-24)
src/ubuntu-video-search.vala (+8/-3)
tests/unit/Makefile.am (+0/-1)

To merge this branch:

bzr merge lp://qastaging/~mhr3/unity-lens-video/fix-1226573

Related bugs:

Bug #1226004: Unnecessary gvfs-bin dependency	Medium	Fix Committed
Bug #1226573: Refine results from online video searches on the phone	High	Fix Committed

Link a bug report

Reviewer	Review Type	Date Requested	Status
Paweł Stołowski (community)		2013-09-17	Approve on 2013-09-18
PS Jenkins bot (community)	continuous-integration		Approve on 2013-09-17
Review via email: mp+186020@code.qastaging.launchpad.net

Commit message

Simplify the scope, use the non-deprecated API, and pass a form-factor hint to the server.

Description of the change

Simplify the scope, use the non-deprecated API, and pass a form-factor hint to the server.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-09-17:

PASSED: Continuous integration, rev:124
http://jenkins.qa.ubuntu.com/job/unity-lens-video-ci/9/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-video-saucy-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-video-saucy-armhf-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-video-saucy-i386-ci/4

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-lens-video-ci/9/rebuild

review: Approve (continuous-integration)

Revision history for this message

Paweł Stołowski (stolowski) wrote on 2013-09-18:

Looks good and works, but the whole business with RESULT_PREVIEW_ON_LMB seems useless now as Dash always shows previews... Can you remove it (unless you see a reason to fix it, in which case we should probably use x-unity-no-preview://)?

review: Needs Fixing

Revision history for this message

Paweł Stołowski (stolowski) wrote on 2013-09-18:

After discussing this on IRC, it's better to leave it for now as it can potentially break the behavior of current Unity8 shell.

review: Approve