Unity Home Scope

Merge lp://qastaging/~mhr3/unity-scope-home/form-factor-from-hints into lp://qastaging/unity-scope-home

  1. form-factor-from-hints
  2. Merge into trunk
Proposed by Michal Hruby
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 122
Merged at revision: 121
Proposed branch: lp://qastaging/~mhr3/unity-scope-home/form-factor-from-hints
Merge into: lp://qastaging/unity-scope-home
Diff against target: 254 lines (+54/-32)
7 files modified
src/platform-info.vala (+3/-3)
src/scope.vala (+2/-1)
src/search-util.vala (+11/-0)
src/smart-scopes-interface.vala (+17/-6)
src/smart-scopes-metrics.vala (+3/-3)
src/smart-scopes-search.vala (+7/-4)
tests/unit/test-home-scope.vala (+11/-15)
To merge this branch: bzr merge lp://qastaging/~mhr3/unity-scope-home/form-factor-from-hints
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Paweł Stołowski (community) Approve
Review via email: mp+169428@code.qastaging.launchpad.net

Commit message

Extract form-factor from search hints and pass it to SSS.

Description of the change

Extract form-factor from search hints and pass it to SSS.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:121
http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/44/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-amd64-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-armhf-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-i386-ci/8

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-home-ci/44/rebuild

review: Approve (continuous-integration)
lp://qastaging/~mhr3/unity-scope-home/form-factor-from-hints updated
122. By Michal Hruby

Move form_factor function to SearchUtil namespace

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Looks good. +1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:122
http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/45/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-amd64-ci/9
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-armhf-ci/9/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-i386-ci/9

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-home-ci/45/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Transient archive issue (Hash sum mismatch). Re-trying.

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:122
http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/46/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-amd64-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-armhf-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-i386-ci/10

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-home-ci/46/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: