Unity Home Scope

Merge lp://qastaging/~mhr3/unity-scope-home/sort-dedup-fix into lp://qastaging/unity-scope-home

  1. sort-dedup-fix
  2. Merge into trunk
Proposed by Michal Hruby
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 143
Merged at revision: 140
Proposed branch: lp://qastaging/~mhr3/unity-scope-home/sort-dedup-fix
Merge into: lp://qastaging/unity-scope-home
Diff against target: 114 lines (+36/-5)
4 files modified
data/master-scopes/applications.scope.in.in (+3/-0)
src/master-scopes.vala (+12/-2)
src/scope-definitions-parser.vala (+16/-3)
tests/unit/test-home-scope.vala (+5/-0)
To merge this branch: bzr merge lp://qastaging/~mhr3/unity-scope-home/sort-dedup-fix
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
PS Jenkins bot (community) continuous-integration Approve
James Henstridge Approve
Review via email: mp+178457@code.qastaging.launchpad.net

Commit message

Make sorting and deduplication actually work.

Description of the change

Make sorting and deduplication actually work.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:141
http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/58/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-amd64-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-armhf-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-i386-ci/22

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-home-ci/58/rebuild

review: Approve (continuous-integration)
Revision history for this message
James Henstridge (jamesh) wrote :

Looks good.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-scope-home-autolanding/49/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/generic-cleanup-mbs/1231/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-amd64-autolanding/19/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-armhf-autolanding/19/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-i386-autolanding/19/console

review: Needs Fixing (continuous-integration)
lp://qastaging/~mhr3/unity-scope-home/sort-dedup-fix updated
142. By Michal Hruby

Set proper XDG_DATA_DIRS

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:142
http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/59/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-amd64-ci/23/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-armhf-ci/23/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-i386-ci/23/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-home-ci/59/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~mhr3/unity-scope-home/sort-dedup-fix updated
143. By Michal Hruby

Fallback to standard XDG_DATA_DIRS if it's not specified

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:143
http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/60/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-amd64-ci/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-armhf-ci/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-home-saucy-i386-ci/24

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-scope-home-ci/60/rebuild

review: Approve (continuous-integration)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Looks good. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: