Merge lp://qastaging/~mhr3/unity/a-few-fixes into lp://qastaging/unity
Proposed by
Michal Hruby
| Status: | Merged |
|---|---|
| Approved by: | Michal Hruby |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 2285 |
| Proposed branch: | lp://qastaging/~mhr3/unity/a-few-fixes |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
64 lines (+13/-7) 4 files modified
UnityCore/GLibSignal.cpp (+1/-1) UnityCore/Hud.cpp (+5/-5) plugins/unityshell/src/DebugDBusInterface.cpp (+2/-1) plugins/unityshell/src/PanelMenuView.cpp (+5/-0) |
| To merge this branch: | bzr merge lp://qastaging/~mhr3/unity/a-few-fixes |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Marco Trevisan (Treviño) | Approve | ||
|
Review via email:
|
|||
Commit message
Fix a couple of wrong reference/memory management issues
Description of the change
Fix a couple of possible crashes:
1) The debug interface was unreferencing a variant that it didn't own
2) Hud was freeing strings that g_variant_iter_loop frees itself
3) PanelMenuView was disconnecting signal on an object that could be already dead
As for tests, the hud AP tests were crashing without these fixes, now unity survives them :)
To post a comment you must log in.
Revision history for this message
| Unity Merger (unity-merger) wrote | # |
Revision history for this message
| Tim Penhey (thumper) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good to me ;)