Unity

Merge lp://qastaging/~mhr3/unity/fix-947301 into lp://qastaging/unity

fix-947301
Merge into trunk

Proposed by Michal Hruby on 2012-03-05

Status:

Merged

Approved by:

Gord Allott on 2012-03-06

Approved revision:

no longer in the source branch.

Merged at revision:

2080

Proposed branch:

lp://qastaging/~mhr3/unity/fix-947301

Merge into:

lp://qastaging/unity

Diff against target:

69 lines (+20/-5)

4 files modified

UnityCore/HomeLens.cpp (+2/-2)
UnityCore/Lens.cpp (+2/-2)
manual-tests/Lenses.txt (+15/-0)
plugins/unityshell/src/LensView.cpp (+1/-1)

To merge this branch:

bzr merge lp://qastaging/~mhr3/unity/fix-947301

Medium

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Mirco Müller (community)	2012-03-05	Approve on 2012-03-06
Gord Allott (community)		Approve on 2012-03-06
Review via email: mp+95957@code.qastaging.launchpad.net

Description of the change

== The Problem ==
Crashed lens doesn't restart unless searching in home view.

== The Solution ==
Make sure a Search call can restart a lens just as GlobalSearch can.

== Testing ==
Added a manual test for the issue.

Revision history for this message

Gord Allott (gordallott) wrote on 2012-03-06:

works but killall unity-applications-daemon won't work for precice unity, killall can't find it. requires
killall /usr/lib/unity-lens-applications/unity-applications-daemon

so the manual test needs to be fixed up

review: Needs Fixing

Revision history for this message

Gord Allott (gordallott) wrote on 2012-03-06:

review: Approve

Revision history for this message

Mirco Müller (macslow) wrote on 2012-03-06:

I've been able to reproduce your manual-test, but on my system I've to use:

killall unity-applicati

The reason for this truncated process-name currently escapes me. If I do the stated:

killall unity-applications-daemon

... I get the response that a process with that name could not be found. Any idea?

Revision history for this message

Mirco Müller (macslow) wrote on 2012-03-06:

Since this seems to be a current (but odd) feature of Precise and not only happening on my system I'm good with approving your branch.

review: Approve

Revision history for this message

Mikkel Kamstrup Erlandsen (kamstrup) wrote on 2012-03-12:

I always use pkill instead of killall. Just 'pkill -f
unity-applications-daemon'. That definitely works. This reminds me
that we should really add a --replace switch to all dameons. Oh, have
I missed that a gajillion times or more!